Closed
Bug 1629192
Opened 4 years ago
Closed 4 years ago
Add some uses of selection statements with initializers to the tree
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
In other words, if (T v = ...; cond)
and switch (T v = ...; expr)
.
Some fumbling regexp searches in mozilla-central indicate no uses of either syntax yet. And it's not on the "Using" page yet, either. gcc 7 (we require 7.1) and clang 3.9 (we require 5.0) and MSVC 2017 15.3 (we use fold expressions that require MSVC 2017 15.5) were the first versions to provide support, so we should be good...but there's no test like a clean try-run and actual in-tree use to prove fitness. Let's add some uses!
Assignee | ||
Comment 1•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/dafc4c96797f Add uses of C++17's new |if (T v = ...; cond)| and |switch (T v = ...; value)| syntax to verify their usability with current compiler requirements. r=sfink
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Assignee | ||
Comment 4•4 years ago
|
||
I updated https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code to note this syntax is safe to use.
You need to log in
before you can comment on or make changes to this bug.
Description
•