1629284 - Crash in [@ nsGlobalWindowInner::UpdateParentTarget]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Sean Feng [:sefeng211]]

This bug is for crash report bp-fde70674-6b99-408e-a1ae-88c550200408.

Top 10 frames of crashing thread:

0 libxul.so nsGlobalWindowInner::UpdateParentTarget dom/base/nsGlobalWindowInner.cpp:1801
1 libxul.so mozilla::EventDispatcher::Dispatch dom/base/nsPIDOMWindow.h:358
2 libxul.so nsINode::DispatchEvent dom/base/nsINode.cpp:1259
3 libxul.so mozilla::dom::EventTarget::DispatchEvent dom/events/EventTarget.cpp:178
4 libxul.so mozilla::AsyncEventDispatcher::Run dom/events/AsyncEventDispatcher.cpp:69
5 libxul.so mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:282
6 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
7 libxul.so <name omitted> xpcom/threads/nsThreadUtils.cpp:486
8 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87
9 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Null+offset.
I guess mParentTarget should be just null if outerwindow is null.
https://hg.mozilla.org/releases/mozilla-release/annotate/c6e493873ba543907dadabb42b64208a3679d43d/dom/base/nsGlobalWindowInner.cpp#l1801

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This looks old, there are crash reports from FF60 for example.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1629284 - null check outer window before using it, r=edgar

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b98dddd0533
null check outer window before using it, r=edgar

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6b98dddd0533