1629293 - Expose js::ErrorReport in public JSAPI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Tom S. (please needinfo tschuster)]

js::ErrorReport is almost always required for error reporting code. PrintError, which we want to expose (Bug 1505129), basically requires it as well. Before we move this we should probably switch init to exclusively support JS::ExceptionStack.

Comment 1

[Philip Chimento [:ptomato]]

I've started working on this, how does JS::ErrorReportBuilder sound for a name?

Comment 2

[Philip Chimento [:ptomato]]

Attachment: Bug 1629293 - Expose js::ErrorReport in public API. r?evilpie

Renames it to JS::ErrorReportBuilder, since it is used to 'build' a
JSErrorReport object.

Depends on D73520

Comment 3

[Philip Chimento [:ptomato]]

Attachment: Bug 1629293 - Make JS::ErrorReportBuilder::init exclusively support JS::ExceptionStack. r?evilpie

Depends on D73521

Comment 4

[Philip Chimento [:ptomato]]

Attachment: Bug 1629293 - Make JS::PrintError take either JSErrorReport or JS::ErrorReportBuilder. r?evilpie

From the existing usage of the function, it seems like it should either
take a JSErrorReport with no toStringResult, or a JS::ErrorReportBuilder
where it can get both the JSErrorReport and the toStringResult.

Depends on D73522

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72a63e290177
Expose js::ErrorReport in public API. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/452e9ab721bd
Make JS::ErrorReportBuilder::init exclusively support JS::ExceptionStack. r=evilpie,mccr8
https://hg.mozilla.org/integration/autoland/rev/ad1ccad76686
Make JS::PrintError take either JSErrorReport or JS::ErrorReportBuilder. r=evilpie

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on for bustages on testPrintError.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea102a49618733aae60628d0f4304e8708274016
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302143544&repo=autoland&lineNumber=7304

Comment 7

[Philip Chimento [:ptomato]]

No changes needed to these patches, but I've updated the patches from bug 1505129 and bug 1506323 to fix the build failures. Here's a retry of the jobs that failed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=880f1222a163c8cbd31c1ebf88a25603755990b4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7f7f6a60ceb
Expose js::ErrorReport in public API. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/4291380d58ef
Make JS::ErrorReportBuilder::init exclusively support JS::ExceptionStack. r=evilpie,mccr8
https://hg.mozilla.org/integration/autoland/rev/93a40cd62fa2
Make JS::PrintError take either JSErrorReport or JS::ErrorReportBuilder. r=evilpie

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e7f7f6a60ceb
https://hg.mozilla.org/mozilla-central/rev/4291380d58ef
https://hg.mozilla.org/mozilla-central/rev/93a40cd62fa2