Closed Bug 1629303 Opened 11 months ago Closed 9 months ago

Megabar expanding/shrinking issue and epilepsy

Categories

(Firefox :: Address Bar, defect, P2)

75 Branch
defect
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Status
firefox-esr68 --- unaffected
firefox77 --- wontfix
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: jandatroy, Assigned: harry)

References

(Blocks 3 open bugs)

Details

(Keywords: access, losing-users, Whiteboard: [access-s3])

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

update to the new Firefox 75 version
use the address bar

Actual results:

the expanding and shrinking of the address bar has caused triggers with my epilepsy. the sudden expanding and then when moving away from the address bar has a similar effect as a strobe light and has triggerd mild symptoms of epilepsy such as losing focus, feeling mildly dizzy, and eye studdering (eye movements like little jerks)

I want to make a point that these are mild reaction and although I don't end up on the floor having an epileptic seizure, the effects to cause stress and triggers which could lead to that end result

Expected results:

Disabling the new function the issues cease to happen.

Component: Untriaged → Address Bar
Keywords: access

Have you set your OS to reduced motion? The addressbar should respect that setting. Other than that, when you focus the addressbar there's a pop-up (user initiated, like any other menu or pop-up) that seems to be causing you issues. How do you deal with menus popping up or select widgets or other items that pop up on user activation? Note, we're probably going to include a preference for not popping up on focus.

(In reply to Asa Dotzler [:asa] from comment #1)

Have you set your OS to reduced motion? The addressbar should respect that setting. Other than that, when you focus the addressbar there's a pop-up (user initiated, like any other menu or pop-up) that seems to be causing you issues. How do you deal with menus popping up or select widgets or other items that pop up on user activation? Note, we're probably going to include a preference for not popping up on focus.

I don't use widgets and employ a popup blocker I try to limit animations from within Firefox and also disable windows animations in Windows 10. I keep Firefox open maximized. I open new links in tabs and wait for the tab to load before switching to it. To limit sudden movements I generally type out urls or ctrl-c/ctrl-v when ever possible. I also take medication that helps to a point. But as someone whom uses the address-bar a lot, the expanding/shrinking has been a little rough to say the least. I have disabled it for now but in the future lets say post FF77 that will not be an option.

Normal menus and widgets just drop the list in one dimension and often on demand (down arrow). Megabar shadows and dimension change makes it popping "out the screen". Reduced motion pref changes nothing in this case.

(In reply to gwarser from comment #3)

Normal menus and widgets just drop the list in one dimension and often on demand (down arrow). Megabar shadows and dimension change makes it popping "out the screen". Reduced motion pref changes nothing in this case.

Agreed

(In reply to Asa Dotzler [:asa] from comment #1)

How do you deal with menus popping up or select widgets or other items that pop up on user activation?

The difference here is that even with animation disabled it still opens in two stages, first the enlargement and then the dropdown, which gives the illusion of animation. Most menus don't have that extra step, if it rendered all at once it should be much less problematic.

Note this was/is in response to Marco Bonardo, on a different bug but directed at me and my bug report

(In reply to Marco Bonardo [:mak] from comment #12)

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #10)

    The dark theme can't be fully recommended to users for this purpose: bug 1566685 (Apart from that the Dark Mode extension is quite ok, but not perfect. Unfortunately it's often better to keep everything bright, but it has its own drawbacks.)

That means the real problem is the dark theme. I admit that's not a trivial problem to solve.

(In reply to Troy Janda from comment #11)

    The sudden expanding and shrinking are the issue for me being a frequent address bar user.

We'd love to hear more feedback from you!
Which part of the urlbar makes you suffer:

    it expands when you open a new tab. I'd expect this to be a lesser problem, because when the tab opens the urlbar is already expanded, so there's no movement.

I open links in new tab and wait for it to fully load before moving to the tab.

    it's larger when it expands the results pane on focus, if you set browser.urlbar.openViewOnFocus it is better

The act of expanding/shrinking simulates a strobe light. I type out most of my urls so accessing the url bar is a constant necessity for me and oce moving away from the url bar it shrinks imagine doing this 30-40 times in an hour.

    it's exactly the same with browser.urlbar.openViewOnFocus

    Try this click on the address bar move away and repeat several times.

But this is not a common operation for any user, I could find flashing defects in any software if I'd just repeat the same action continuously. We'd like to concentrate on your everyday needs more than simulated examples.

What is common to some might not be to others not sure how you can justify this statement, I am not talking about other software or conducting simulated examples, what I have described is my reality! these are the things that I PERSONALLY do each and everyday in my life to limit my triggers. I can't speak for neural sensitive/motion sensitivity I can talk about epilepsy.

No you can't be 100% trigger free some motion effects are different than others, some cause mild symptoms while others can trigger a full onset seizure. My trigger is stuff moving toward me or away from me in quick succession. As i use the bar 30-40 times an hour on average.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Can you please explain better how it is with browser.urlbar.openViewOnFocus set to false? with that false we don't open the results pane, so the effect should be much smaller. I'd like to better understand the strobe effect when the panel doesn't open.

Flags: needinfo?(jandatroy)

(In reply to Marco Bonardo [:mak] from comment #7)

Can you please explain better how it is with browser.urlbar.openViewOnFocus set to false? with that false we don't open the results pane, so the effect should be much smaller. I'd like to better understand the strobe effect when the panel doesn't open.

It the popout and shrink that triggers my symptoms. Clicking on the url it expands, then navigating away from the bar it shrinks. I use the bar to type out address and I do this 20-30 times an hour typically on average the effects case my eyes to studder (Rapid eye movement) this in turn starts to make me dizzy. As I said I have not had a full blown epileptic episode but the symptoms are no less disrupting.

browser.urlbar.openViewOnFocus I have it set to false I also have the whole new bar disabled I just can't handle the constant expanding/shrinking. I have tried and do limit animations as I have said. Its a daily challenge to find ways to limit my triggers.

The strobe affect is like someone turning on and off a light, making quick forward movements or anything that causes the eyes to studder. movement downward is less symptomatic.

Some triggers are different for different people I am just explaining my triggers and why its a concern. For a person such as me using the url bar many times in an hour the effects are causing me problems.

Flags: needinfo?(jandatroy)

(In reply to Troy Janda from comment #8)

browser.urlbar.openViewOnFocus I have it set to false I also have the whole new bar disabled

I see, but in practice I'm asking if you tried to keep the new design enabled but browser.urlbar.openViewOnFocus disabled.

(In reply to Marco Bonardo [:mak] from comment #9)

(In reply to Troy Janda from comment #8)

browser.urlbar.openViewOnFocus I have it set to false I also have the whole new bar disabled

I see, but in practice I'm asking if you tried to keep the new design enabled but browser.urlbar.openViewOnFocus disabled.

Yes very limited the drop down part helps but after several click on the url and moving away still presents a problem.

maybe a pref to disable the expanding/shrinking in addition to the browser.urlbar.openViewOnFocus disabled pref

I have no issues or history with epilepsy, but I do have mild dyslexia and motion sickness in cars. I'll often open a new tab with an intent of doing something, and the bar expanding whether I used it or clicked one of the top sites kept distracting me from what it was I was trying to do. I first thought it was just the novelty of it, but I kept losing my focus after extended use.

I think the bar popping out makes it look a lot like a notification bar, and it's equally successful in stealing my attention. I tend to limit or disable system notifications when possible, on laptop and phone, to keep myself from being distracted and keep my work flow in tact. I also have a flip cover on my phone so that even if I do get a notification, I don't see it until I explicitly want to check if I got any.

I have not tried running it with animations disabled yet, so I'll try that now and see if that helps. I never had any issue with UI animation in general, but it might be that the animation itself is what brings my attention to the bar.

(In reply to maciej.hirsz from comment #12)

I have not tried running it with animations disabled yet, so I'll try that now and see if that helps. I never had any issue with UI animation in general, but it might be that the animation itself is what brings my attention to the bar.

As I said above, try setting browser.urlbar.openViewOnFocus to false, use the dark theme if you're distracted by flashes, and let us know if things improve.

Keywords: blocked-ux
Priority: -- → P2

I have dark theme on and openViewOnFocus set to false. Using it since yesterday evening with animations disabled it's definitely much better and something I can get used to. I wish I could disable the bar animation separately from OS settings, since I actually don't have any issues with my OS animations and quite like them (Gnome DE). I don't have issues with animations in general (no headaches or motion sickness from staring at them), my only issue is the distraction the bar animating triggers when I don't (intend to) interact with it, if that makes sense.

(In reply to Marco Bonardo [:mak] from comment #13)

(In reply to maciej.hirsz from comment #12)

I have not tried running it with animations disabled yet, so I'll try that now and see if that helps. I never had any issue with UI animation in general, but it might be that the animation itself is what brings my attention to the bar.

As I said above, try setting browser.urlbar.openViewOnFocus to false, use the dark theme if you're distracted by flashes, and let us know if things improve.

(In reply to Marco Bonardo [:mak] from comment #9)

(In reply to Troy Janda from comment #8)

    browser.urlbar.openViewOnFocus I have it set to false I also have the whole new bar disabled

I see, but in practice I'm asking if you tried to keep the new design enabled but browser.urlbar.openViewOnFocus disabled.

Yes very limited the drop down part helps but after several click on the url and moving away still presents a problem.

Blocks: 1630275
No longer blocks: urlbar-update-1
Whiteboard: [access-p2]

I personally do not like the urlbar expansion either because I find it distracting. Recently I found a way using userChrome.css to disable this expansion. Maybe you coud try it and see if it works better for you. Source

/* --- Disable expanding --- */
#urlbar[breakout][breakout-extend] {
  top: calc((var(--urlbar-toolbar-height) - var(--urlbar-height)) / 2) !important;
  left: 0 !important;
  width: 100% !important;
}

#urlbar[breakout][breakout-extend] > #urlbar-input-container {
  height: var(--urlbar-height) !important;
  padding-block: 0px !important;
  padding-inline: 0px !important;
}

#urlbar[breakout][breakout-extend][breakout-extend-animate] > #urlbar-background {
  animation-name: none !important;
}

(In reply to trinywiky from comment #16)

I personally do not like the urlbar expansion either because I find it distracting. Recently I found a way using userChrome.css to disable this expansion. Maybe you coud try it and see if it works better for you. Source

/* --- Disable expanding --- */
#urlbar[breakout][breakout-extend] {
  top: calc((var(--urlbar-toolbar-height) - var(--urlbar-height)) / 2) !important;
  left: 0 !important;
  width: 100% !important;
}

#urlbar[breakout][breakout-extend] > #urlbar-input-container {
  height: var(--urlbar-height) !important;
  padding-block: 0px !important;
  padding-inline: 0px !important;
}

#urlbar[breakout][breakout-extend][breakout-extend-animate] > #urlbar-background {
  animation-name: none !important;
}

To be a bit simpler I have just flipped the pref to false to disable it. Ill have to move to this or another solution once they take away those prefs, from what I have heard this will be in FF77. If this is so, FF76 will be my last.

Keywords: losing-users

Resetting severity to default of --.

Points: --- → 5

May I ask what points are? I saw Mr. Bonardo make a change adding 5 points, Sorry if this has been asked before still new to the process.

It's just an estimate of the difficulty to fix the bug, depending on it scomplexity and needed interactions with other people/teams. Nothing of interest for users, we use it to estimate team velocity.

We're happy that you're helping us out by filing a bug report and providing useful information that'll help our engineers move towards a solution to the issue!
If you have additional relevant information to share, please feel free to post them to the bug. But since this is a work tracker, I'd like to ask if you could join us on Matrix (on chat.mozilla.org, we're at the #search channel) for any other questions or concerns you might have.

Thank you.

Updating the Accessibility Team's impact assessment to conform with the new triage guidelines. See https://wiki.mozilla.org/Accessibility/Triage for descriptions of these whiteboard flags.

Whiteboard: [access-p2] → [access-s3]
Blocks: 1478597
Assignee: nobody → htwyford
Keywords: blocked-ux

We're going to disable the expansion effect when the panel is closed and the "Reduce motion" OS preference is enabled. Since there's a great deal of interest in this bug, I'll note that we're also looking at modifying the address bar design in compact mode over in bug 1630508.

Status: NEW → ASSIGNED
Iteration: --- → 79.1 - June 1 - June 14

(In reply to Harry Twyford [:harry] from comment #28)

We're going to disable the expansion effect when the panel is closed and the "Reduce motion" OS preference is enabled. Since there's a great deal of interest in this bug, I'll note that we're also looking at modifying the address bar design in compact mode over in bug 1630508.

Panel? Is that the urlbar not understanding, so the urlbar will not expand/shrink if the "Reduce motion" OS preference is enabled?

The panel displays results. So there will be no expansion when opening a new tab, but there will be an expansion once one interacts with the address bar, since we need to show results.

(In reply to Harry Twyford [:harry] from comment #30)

The panel displays results. So there will be no expansion when opening a new tab, but there will be an expansion once one interacts with the address bar, since we need to show results.

Not sure I understand, Im sorry, so clicking the urlbar (panel) which triggers the expansion will be disabled? but the drop down results will remain the same or I am lost as to what exactly you mean.

I open all links in new tabs and wait a bit before switching to that tab to help minimize the effects. However since I use the urlbar a lot the expansion/shrinking when its in focus and moving away is the main issue. I think that a simple pref to disable that expansion is not unreasonable.

Attached image new states.png

Right now, the address bar has three states:

  1. Unfocused
  2. Focused & expanded
  3. Focused, expanded, & open

State 1 is what you see when you're not interacting with the address bar. You enter state 2 when you open a new tab but haven't interacted with the address bar yet. You enter state 3 after clicking or typing in the address bar, and results are shown in the dropdown panel.

My patch just changes state 2 so it's not expanded. This will eliminate the motion effect when opening a new tab. I've attached a screenshot to illustrate what things will look like after my patch is applied.

Not sure how this relates to my bug report. It is the expanding/shrinking of the urlbar, not opening a new tab.

when clicking the urlbar it expands, when moving away, or clicking outside the urlbar is shrinks. this is my issue because as many times that I use the urlbar the constant expansion/shrinking is causing my issues. New tab was never my issue as when I right click to open links in new tabs I wait till the tab loads before switching to it.

By expanding, do you mean how we show Top Sites when you click on the Urlbar? You can disable that in 78+ in about:preferences > Privacy & Security > Address bar > Uncheck "Top sites". In <78 you can disable the pref browser.urlbar.openViewOnFocus. You and Marco discussed that earlier in the thread. With that behaviour disabled, the address bar will not move when it is clicked once my patch is applied.

It might be easier to try my patch out in Nightly once it lands and offer feedback on it.

(In reply to Harry Twyford [:harry] from comment #35)

By expanding, do you mean how we show Top Sites when you click on the Urlbar? You can disable that in 78+ in about:preferences > Privacy & Security > Address bar > Uncheck "Top sites". In <78 you can disable the pref browser.urlbar.openViewOnFocus. You and Marco discuss that earlier in the thread. With that behaviour disabled, the address bar will not move when it is clicked once my patch is applied.

It might be easier to try my patch out in Nightly once it lands and offer feedback on it.

By expanding, do you mean how we show Top Sites
No, I already have browser.urlbar.openViewOnFocus set to false and I have unclecked the topsites

My issue is, open Firefox let it load your home page, then click inside the urlbar. It expands, now if you click outside of the urlbar the urlbar shrinks. try doing this over 30-40 times an hour. I hope that this explains this better.

edited for format issue, Harry asked,
By expanding, do you mean how we show Top Sites

my responce,

No, I already have browser.urlbar.openViewOnFocus set to false and I have unclecked the topsites

Troy, per Harry's responses and the image he posted, the expansion will not occur when you click in the bar. It will expand if you type and you get suggestions in the bar, however. Does that help?

(In reply to Asif Youssuff from comment #38)

Troy, per Harry's responses and the image he posted, the expansion will not occur when you click in the bar. It will expand if you type and you get suggestions in the bar, however. Does that help?

His images is for newtab page I am talking about just the act of clicking the urlbar and moving away from the urlbar

(In reply to Asif Youssuff from comment #38)

Troy, per Harry's responses and the image he posted, the expansion will not occur when you click in the bar. It will expand if you type and you get suggestions in the bar, however. Does that help?

browser.urlbar.openViewOnFocus set to false stops the dropdown and the suggestions

Steps

  1. open Firefox,
  2. click inside the urlbar,
    Result it expands before you even start typing.
  3. move/clicking outside the urlbar,
    Results the urlbar shrinks to its unfocused state.

I already control how tabs are loaded, I right click link and open in newtab and only switch to that tab once its fully loaded.

(In reply to Troy Janda from comment #40)

Steps

  1. open Firefox,
  2. click inside the urlbar,
    Result it expands before you even start typing.
  3. move/clicking outside the urlbar,
    Results the urlbar shrinks to its unfocused state.

I already control how tabs are loaded, I right click link and open in newtab and only switch to that tab once its fully loaded.

In this bug, Harry has made it so that step 2 will not expand. Refer to the image.

on newtab(In reply to Asif Youssuff from comment #41)

(In reply to Troy Janda from comment #40)

Steps

  1. open Firefox,
  2. click inside the urlbar,
    Result it expands before you even start typing.
  3. move/clicking outside the urlbar,
    Results the urlbar shrinks to its unfocused state.

I already control how tabs are loaded, I right click link and open in newtab and only switch to that tab once its fully loaded.

In this bug, Harry has made it so that step 2 will not expand. Refer to the image.

On "Newtab" clearly Im not talking about on newtab

(In reply to Troy Janda from comment #42)

On "Newtab" clearly Im not talking about on newtab

I was just using the new tab as an example. I expect my patch will do what you are requesting. To avoid creating too much bug mail, please wait for the patch to land then let us know if it does what you expect.

(In reply to Harry Twyford [:harry] from comment #43)

(In reply to Troy Janda from comment #42)

On "Newtab" clearly Im not talking about on newtab

I was just using the new tab as an example. I expect my patch will do what you are requesting. To avoid creating too much bug mail, please wait for the patch to land then let us know if it does what you expect.

is it not what this is for a discussion, input and debate? Can I ask when this is expected to land? I don't use beta, or nightly because it too much work to reset up to act like stable.

Attached video no_expand.mov

(In reply to Troy Janda from comment #44)

(In reply to Harry Twyford [:harry] from comment #43)
is it not what this is for a discussion, input and debate?

Yes, but I think we're in agreement. You don't want the address bar to expand when it is clicked, and my patch does that.

Can I ask when this is expected to land?

It will most likely be in Firefox 79. We may still be able to get it into Firefox 78 it it doesn't create any additional issues. Since you don't use Nightly or Beta, you won't see the change for at least a few weeks. Here's a screen recording instead. I click in the address bar a few times, type a bit, press Escape, then open a new tab.

It's a bit difficult to follow the discussion, but I also guess the patch is going to fix the problem. You may have never thought about it, but open source software isn't free as in royalty free. Rather it is free of charge, but depends on a user base that actually tests alpha/beta versions, and ideally is able to hand in patches or bug reports for problems that arise.

To make it short: if you want to test a proposed fix from nightly, just backup your profile and go for it. If you can't do it on your own, go ask a friend to help you with getting the verification you so much demand.

(In reply to Harry Twyford [:harry] from comment #45)

Created attachment 9155391 [details]
no_expand.mov

(In reply to Troy Janda from comment #44)

(In reply to Harry Twyford [:harry] from comment #43)
is it not what this is for a discussion, input and debate?

Yes, but I think we're in agreement. You don't want the address bar to expand when it is clicked, and my patch does that.

Can I ask when this is expected to land?

It will most likely be in Firefox 79. We may still be able to get it into Firefox 78 it it doesn't create any additional issues. Since you don't use Nightly or Beta, you won't see the change for at least a few weeks. Here's a screen recording instead. I click in the address bar a few times, type a bit, press Escape, then open a new tab.

yes I see that is what I am talking about and I assume that browser.urlbar.openViewOnFocus set to false stops the dropdown and the suggestions and you type? I am hoping for zero expansion even while typing. However you patch seems to be great.

(In reply to tt_1 from comment #46)

It's a bit difficult to follow the discussion, but I also guess the patch is going to fix the problem. You may have never thought about it, but open source software isn't free as in royalty free. Rather it is free of charge, but depends on a user base that actually tests alpha/beta versions, and ideally is able to hand in patches or bug reports for problems that arise.

To make it short: if you want to test a proposed fix from nightly, just backup your profile and go for it. If you can't do it on your own, go ask a friend to help you with getting the verification you so much demand.

my disability makes it difficult enough to use Firefox but with the settings and addons I am able to tolerate it. Setting up additional Firefox editions such as Beta, and Nightly is a tall ask to get it to behave in a manor that does not make it trigger my epilepsy. Ill have to wait for this patch to land on stable and check back here for additional information as it becomes available.

(In reply to Troy Janda from comment #47)

I am hoping for zero expansion even while typing.

You can set browser.urlbar.maxRichResults to 0 and there will be no dropdown when you type. Once this patch lands, there would be no motion whatsoever.

(In reply to Harry Twyford [:harry] from comment #49)

(In reply to Troy Janda from comment #47)

I am hoping for zero expansion even while typing.

You can set browser.urlbar.maxRichResults to 0 and there will be no dropdown when you type. Once this patch lands, there would be no motion whatsoever.

Thank you Harry for your time and help.

Question, could that patch be applied to the browser.urlbar.openViewOnFocus pref, when set to false also disables the expansion for people that just don't like the expanding feature? I am asking for the people in the Reddit thread who are not in my situation of being epileptic.

(In reply to Troy Janda from comment #51)

Question, could that patch be applied to the browser.urlbar.openViewOnFocus pref, when set to false also disables the expansion for people that just don't like the expanding feature? I am asking for the people in the Reddit thread who are not in my situation of being epileptic.

The input field extension and openViewOnFocus (Top Sites actually) are different features with different characteristics, it wouldn't make sense to group them under the same pref. Additionally Firefox 78 already contains a visual pref to disable Top Sites.

(In reply to Marco Bonardo [:mak] from comment #52)

(In reply to Troy Janda from comment #51)

Question, could that patch be applied to the browser.urlbar.openViewOnFocus pref, when set to false also disables the expansion for people that just don't like the expanding feature? I am asking for the people in the Reddit thread who are not in my situation of being epileptic.

The input field extension and openViewOnFocus (Top Sites actually) are different features with different characteristics, it wouldn't make sense to group them under the same pref. Additionally Firefox 78 already contains a visual pref to disable Top Sites.

Its not the Top sites I am referring to Mr Bonardo, its the expanding that happen when clicking the urlbar. Not the drop down, not the Topsites just the the expanding that happen when clicking the urlbar in to focus, and the shrinking when clicking outside the urlbar. The above patch will disable that if/when the "reduce motion" OS is enabled & browser.urlbar.openViewOnFocus set to false. Which will be very helpful for me and those with my condition.

I was asking that why can't a pref be made to simply disable the expanding all together? if the user so chooses.

(In reply to Troy Janda from comment #53)

I was asking that why can't a pref be made to simply disable the expanding all together? if the user so chooses.

We're providing a solution for people who actually have accessibility issues with continuous UI changes, prefer-reduced-motion is exactly for that. We can't meet the subjective taste of everyone, of course people can use the same accessibility method to disable the expansion, we can't/won't prevent that.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/153e280928ee
Don't expand the Urlbar when reduce motion is on. r=dao
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

(In reply to Pulse from comment #58)

Just so it's on the table, There is nothing in KDE that will cause the desired effect of stopping the address bar expansion. Works in Windows 10. The only option for KDE seems to be ui.prefersReducedMotion which does seem to work. This should be a made an option under preferences.

Tested in today's nightly Build 20200610214041.

I managed to get the animations disabled via the GTK settings.ini. I'd missed it earlier but was reminded about the process on reddit

(In reply to Pulse from comment #59)

I managed to get the animations disabled via the GTK settings.ini. I'd missed it earlier but was reminded about the process on reddit

Thanks, this may be useful to other users.

Address bar is still expanding when I start typing, check this out in Firefox 79.0a1 (2020-06-10) (64-bit)
check this: https://imgur.com/bRZXJbg

yes, that is expected, we must show the results pane.

Comment on attachment 9155353 [details]
Bug 1629303 - Don't expand the Urlbar when reduce motion is on. r?dao

Beta/Release Uplift Approval Request

  • User impact if declined: This is an accessibility fix for the new address bar ("megabar"). If declined, people with epilepsy or who are otherwise sensitive to motion would not have a way to disable all motion in the address bar. It it worth noting that 78 ESR will be the first ESR version to get the new address bar, and we'd like for this accessibility fix to be included when it launches on that channel.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Visual-only fix. There is only a small amount of code involved, so backout would be simple.
  • String changes made/needed:
Attachment #9155353 - Flags: approval-mozilla-beta?

Comment on attachment 9155353 [details]
Bug 1629303 - Don't expand the Urlbar when reduce motion is on. r?dao

approved for 78.0b7

Attachment #9155353 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 1647833
Blocks: 1647833
No longer depends on: 1647833
Severity: normal → S2
You need to log in before you can comment on or make changes to this bug.