1629350 - startup warning: NS_ENSURE_TRUE(mPresShell) failed

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Cameron McCormack (:heycam)]

There is a warning on startup in builds with MOZ_WAYLAND defined:

WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /z/moz/l/layout/base/nsPresContext.cpp, line 844

This happens when under nsPresContext::Init, when the newly created refresh driver attempts to call into GetRootWidget() here:

https://searchfox.org/mozilla-central/rev/8ed108064bf1c83e508208e069a90cffb4045977/layout/base/nsRefreshDriver.cpp#1043

At this point, the pres context doesn't have a pres shell.

The widget-specific vsync stuff was added in bug 1542808. The warning only seems to fire in content processes, so I want to null check the pres shell to avoid the warning.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1629350 - Don't warn when trying to get a widget-specific vsync source.

This tends to happen in content processes only, but per the commit
message from bug 1542808, we don't provide a widget-specific vsync
source in content processes currently.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760a694ec6ef
Don't warn when trying to get a widget-specific vsync source. r=lsalzman

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/760a694ec6ef