1629420 - ClientWebGLContext.cpp: the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

if (prog.mActiveTfos.size()) {

should use .empty() instead

https://searchfox.org/mozilla-central/source/dom/canvas/ClientWebGLContext.cpp#4692

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 2

[Sneha k]

Attachment: Bug 1629420 - replaced size() with empty(). r?Sylvestre Ledru

Depends on D105867

Comment 3

[rai.ankur0007]

Is this bug still Open? if It is, I love to start with this.

Comment 4

[Andi [:andi]]

(In reply to rai.ankur0007 from comment #3)

Is this bug still Open? if It is, I love to start with this.

Let’s see if the original author is still interested in this, if not you can take it.
@snehasai01 are you still interested in this?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Yeah, the code move to:
https://searchfox.org/mozilla-central/source/dom/canvas/ClientWebGLContext.cpp#5338

Comment 6

[Sneha k]

Attachment: Bug 1629420 - ClientWebGLContext.cpp: the 'empty' method should be used to check for emptiness instead of 'size'. r?Sylvestre

Comment 7

[Sneha k]

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #4)

(In reply to rai.ankur0007 from comment #3)

Is this bug still Open? if It is, I love to start with this.

Let’s see if the original author is still interested in this, if not you can take it.
@snehasai01 are you still interested in this?

Yes, I have submitted a new patch, kindly review.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f509d5be8b07
ClientWebGLContext.cpp: the 'empty' method should be used to check for emptiness instead of 'size'. r=andi

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f509d5be8b07