1629422 - MediaTransportHandler.cpp: redundant string initialization

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1629421 +++

Filling as a good first bug to learn workflows.

std::string alpnDefault = "";

= ""; isn't useful

https://searchfox.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/MediaTransportHandler.cpp#1189

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Comment 1

[chris.cushman]

Attachment: Bug 1629422 - Eliminating redundant initialization in MediaTransportHandler

Comment 2

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bffe0734ac4e3bee4d88a1ffa2a217d7d361ad0d
Setting needinfo for me to follow up and land if it looks green.

Comment 3

[Dan Minor [:dminor]]

Try run is fine, waiting on a typo fix in the commit message before this can land.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f991e9f267
Eliminating redundant initialization in MediaTransportHandler r=dminor

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/24f991e9f267