Closed Bug 1629428 Opened 4 years ago Closed 4 years ago

TestBaseProfiler.cpp: use unary 'static_assert' when the string literal is an empty string

Categories

(Developer Infrastructure :: Source Code Analysis, task)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: Sylvestre, Assigned: arash9k, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Bug 1629428 - Remove empty string in static_assert - r=canaltinova
47 bytes, text/x-phabricator-request
Details | Review

Filling as a good first bug to learn workflows.

, ""); at the end of static_assert is useless

https://searchfox.org/mozilla-central/source/mozglue/tests/TestBaseProfiler.cpp#126-127

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-unary-static-assert.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Assignee: nobody → arash9k
Status: NEW → ASSIGNED
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a7e3cb3cf9ef
Remove empty string in static_assert - r=canaltinova

https://hg.mozilla.org/mozilla-central/rev/a7e3cb3cf9ef

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: