Closed Bug 1629430 Opened 4 months ago Closed 3 months ago

Make use of optional defaultvalue in get*Pref in feeds

Categories

(SeaMonkey :: Feed Discovery and Preview, task)

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.74
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.3)

Attachments

(1 file)

Bug 1338306 introduced the ability to pass a default value with get*Pref, this can be used in the feed code to simplify it.

Attached patch Update get*PrefSplinter Review

This patch:

  • Removes the safeGetCharPref helper
  • Uses Services.prefs.getCharPref(pref, defaultValue) instead
  • Removes try/catch in favour of using Services.prefs.getBoolPref(pref, defaultValue)
Attachment #9140066 - Flags: review?(frgrahl)
Attachment #9140066 - Flags: approval-comm-release?
Attachment #9140066 - Flags: approval-comm-esr60?
Comment on attachment 9140066 [details] [diff] [review]
Update get*Pref

LGTM
Attachment #9140066 - Flags: review?(frgrahl)
Attachment #9140066 - Flags: review+
Attachment #9140066 - Flags: approval-comm-release?
Attachment #9140066 - Flags: approval-comm-release+
Attachment #9140066 - Flags: approval-comm-esr60?
Attachment #9140066 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/92fecd6fc1c2
Make use of optional defaultvalue in get*Pref in feeds. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.74
Whiteboard: SM2.53.3
You need to log in before you can comment on or make changes to this bug.