Closed
Bug 1629430
Opened 5 years ago
Closed 5 years ago
Make use of optional defaultvalue in get*Pref in feeds
Categories
(SeaMonkey :: Feed Discovery and Preview, task)
SeaMonkey
Feed Discovery and Preview
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey 2.74
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.53 | + | fixed |
| seamonkey2.57esr | ? | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.3)
Attachments
(1 file)
|
5.78 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Bug 1338306 introduced the ability to pass a default value with get*Pref, this can be used in the feed code to simplify it.
This patch:
- Removes the safeGetCharPref helper
- Uses Services.prefs.getCharPref(pref, defaultValue) instead
- Removes try/catch in favour of using Services.prefs.getBoolPref(pref, defaultValue)
Attachment #9140066 -
Flags: review?(frgrahl)
Attachment #9140066 -
Flags: approval-comm-release?
Attachment #9140066 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9140066 [details] [diff] [review]
Update get*Pref
LGTM
Attachment #9140066 -
Flags: review?(frgrahl)
Attachment #9140066 -
Flags: review+
Attachment #9140066 -
Flags: approval-comm-release?
Attachment #9140066 -
Flags: approval-comm-release+
Attachment #9140066 -
Flags: approval-comm-esr60?
Attachment #9140066 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/92fecd6fc1c2
Make use of optional defaultvalue in get*Pref in feeds. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Updated•5 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
Target Milestone: --- → seamonkey 2.74
|
|
||
Comment 4•5 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/bfbf6b8474604630f706ac0dab6d89a2de29e093
Make use of optional defaultvalue in get*Pref in feeds. r=frg a=frg
tracking-seamonkey2.53:
--- → +
tracking-seamonkey2.57esr:
--- → ?
You need to log in
before you can comment on or make changes to this bug.
Description
•