1629431 - AppWindow.cpp: converting integer literal to bool, use bool literal instead

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

Replace 1 by true (it is casted to bool anyway)

https://searchfox.org/mozilla-central/source/xpfe/appshell/AppWindow.cpp#1613

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Comment 1

[Abdallah Afify]

Attachment: Bug 1629431 - Use bool true instead of int 1. r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/063fb58eb4c2
Use bool true instead of int 1. r=smaug

Comment 3

[Abdallah Afify]

Hello,

I submitted a Patch and the review is closed, but I am not sure that the change is 'landed'. How can I verify this ? this is my first time submitting a Patch here.

Thank you

Comment 4

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/autoland/rev/063fb58eb4c2 it means that your change is being processed and should arrive in mozilla-central

See the various tests being run:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=063fb58eb4c2

Comment 5

[Abdallah Afify]

and after that the ticket will be automatically closed ?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

yes!

Comment 7

[Abdallah Afify]

Okay, Thank you.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/063fb58eb4c2