In inspector, clicking on event creates unreadable tooltip
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
People
(Reporter: erwinm, Unassigned)
Details
Attachments
(3 files)
Screen Shot 2020-04-13 at 2.26.37 AM.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:75.0) Gecko/20100101 Firefox/75.0
Steps to reproduce:
Tried to detect why certain elements were jumping around. Opened inspector. Saw something labelled an event, tried to click the element line, clicked event, got an unreadable tooltip. I assume it's supposed to be readable. Screenshot attached.
Actual results:
It was unreadable because (1) the text extended off the left edge, and (2) when I tried to click on it to see if I could find out what was beyond the left edge, it started firing a blinking cursor. And I can't see near blinking or flashing objects.
(1) may be a result of my font css.
(2) is definitely not a result of my about:config fixes to stop blinking cursors, because (2a) it hasn't stopped the cursors and (2b) if it had stopped the cursors, it wouldn't be a problem.
Expected results:
(1) the tooltip should be large enough to include reasonably-sized text, and
(2) the cursor shouldn't blink if users use ui.caretBlinkTime 0, or use reduced motion preferences, or use other cursor-blocking fixes.
|
||
Comment 1•6 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
||
Comment 2•6 years ago
|
||
(1) - Can you please share a reduced test case or a page where this tooltip is broken? I can't reproduce the issue on bugzilla.mozilla.org
(2) - Bug 1609567 which introduced the change to respect the ui.caretBlinkTime pref has landed in Firefox 76. Firefox Stable is now on 75. It will move up to 76 soon and the pref will be respected in the tooltip as well. I checked in current Nightly (Firefox 77) and the cursor does not blink when the pref is set.
(1) not at the moment.
(2) I tried Beta 2 days ago, it would still blink, faster and more erratically.
|
|
||
Comment 6•6 years ago
•
|
||
(In reply to MarjaE from comment #3)
(2) I tried Beta 2 days ago, it would still blink, faster and more erratically.
Strange. I just tried it in 76.0b5 (64-bit) and the pref is respected.
Can you try current Firefox Nightly and let me know if the blinking stops when ui.caretBlinkTime pref is set to 0?
You mentioned
(1) may be a result of my font css.
I wasn't able to reproduce (1) either on this page on bugzilla.mozilla.org, or elsewhere with the stock Nightly / DevEdition / Release styles. Could it be an oversized custom font-size causing it?
/* Global UI font */
- { font-family: Andika !important; }
- { font-size: 16pt !important; }
#urlbar { height: 20pt }
Which is large enough to read without eyestrain. Default is too small.
|
|
||
Comment 8•6 years ago
•
|
||
{ font-size: 16pt !important; }
I don't exactly where this is set, but the custom font-size of 16pt is oversized for the input. Adding it manually to the editor instance shows similar results.
So I guess this bug originates from the custom styling.
The tooltip for event handlers has a fixed width set here:
https://searchfox.org/mozilla-central/rev/567b68b8ff4b6d607ba34a6f1926873d21a7b4d7/devtools/client/shared/widgets/tooltip/EventTooltipHelper.js#16
There are many DevTools states where this tooltip appears. Changing this size is unlikely.
I don't know how you're editing your styles, but if you want to set custom styles for the editors, this is the stylesheet which adds Firefox's styles to Code Mirror:
https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/codemirror/mozilla.css
I don't know what code mirror is. But I use user css to make text readable. If the text is too small, then it's not readable. If the layout is designed so that readably-sized text isn't readable, leaving it unreadable small isn't going to make it readable either.
And yes I've tried full page zoom, but that breaks scrolling, and by the time I make the small standard text readable, header text is often unreadable.
I've also tried using the preferences, but the current preference pages aren't very accessible and they run into all the same problems as user css.
|
|
||
Comment 10•6 years ago
|
||
Agreed, it would be nice to have options exposed for users to edit their preferred styling for DevTools. Unfortunately, that's not close on the roadmap.
The issue (1) here stems from custom user configuration and not from default DevTools styling. Given this, I'm going to close this bug.
If the cursor blinking pref is not respected with the latest Nightly or Firefox Beta, please open a separate issue.
Description
•