1629521 - Make dynamic-toolbar-sticky-??.html tests pass on desktop

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1628484 I'm adding a bunch of position:sticky tests. While the tests are mostly intended to exercise various dynamic toolbar cases, they also exercise previously-unexercised codepaths even without the dynamic toolbar. There are a number of failures with WR enabled. This bug will fix those non-dynamic-toolbar cases.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0c6b9ba533eb896c2cd84a3a0755fc2cfafc1825

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1629521 - Improve behaviour when items have both top and bottom sticky ranges. r?jrmuizel,kvark

The sticky info emitted by Gecko to WR wasn't quite correct in some cases
where sticky items had both top and bottom sticky ranges. This corrects
the info emitted by Gecko. This change makes a few of the failing tests
pass, but also makes one fail. That one failure was previously passing due
to two bugs canceling each other out, and is fixed up in the next patch.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1629521 - Fix WR handling of items with both top and bottom sticky ranges. r?jrmuizel,kvark

The WR code that computed the sticky_offset didn't properly combine the offsets
from the top- and bottom- sticky calculations if an item had both. This patch
fixes the calculation, which makes the remaining test failure (in the
configuration without any dynamic toolbar) pass.

Depends on D70679

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45a80338f459
Improve behaviour when items have both top and bottom sticky ranges. r=kvark
https://hg.mozilla.org/integration/autoland/rev/2c065921de09
Fix WR handling of items with both top and bottom sticky ranges. r=kvark

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/45a80338f459
https://hg.mozilla.org/mozilla-central/rev/2c065921de09