1629650 - nsFlexContainerFrame::ComputeFinalSize variable "reflowOutputInFlexWM" is mis-named

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Description

[Daniel Holbert [:dholbert]]

Just noticed this when re-reading the implementation of nsFlexContainerFrame::ComputeFinalSize:

  // Compute flex container's reflow-output measurements (in its own
  // writing-mode), starting w/ content-box size & growing from there:
  LogicalSize reflowOutputInFlexWM =
      aAxisTracker.LogicalSizeFromFlexRelativeSizes(aContentBoxMainSize,
                                                    aContentBoxCrossSize);

This variable's name doesn't make sense. Its name use to be desiredSizeInFlexWM (which does make sense) but it was caught up in a slightly overzealous search-and-replace, in bug 1621989 part 1. (That search-and-replace meant to rename ReflowOutput-typed variables, which were traditionally often named "DesiredSize"; but this particular variable is not a ReflowOutput and is a "desired size", so it should not have been renamed.)

After bug 1627125 lands (which has a rewriting of this function), we should rename this particular variable back to desiredSizeInFlexWM or something like it.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I can take care of this.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1629650 - Rename flex container's desired size back to desiredSizeInFlexWM. r=dholbert

This was mis-renamed in bug 1621989 Part 1.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2796692264cd
Rename flex container's desired size back to desiredSizeInFlexWM. r=dholbert

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2796692264cd