1629655 - ckfw needs to support temporary session objects.

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Robert Relyea]

libcurl uses libpem which uses ckfw to create temporary objects whose space needs to be freed after use (rather than at token shutdown). Currently only token objects are supported and they are allocated out of a global arena owned by the slot, so the objects only go away when the slot is closed. This is a problem for long running servers.

The overall fix requires changes to libcurl and libpem, but we also need support in nss's ckfw. This bug is only for NSS's portion of the fix. Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1688958

Comment 1

[Robert Relyea]

Attachment: Bug 1629655 ckfw needs to support temporary session objects.

libckfw needs to create temporary objects whose space will to be freed after
use (rather than at token shutdown). Currently only token objects are supported
and they are allocated out of a global arena owned by the slot, so the objects
only go away when the slot is closed.

This patch sets the arena to NULL in nssCKFWObject_Create() if the object is
a session object. This tells nssCKFWObject_Create() to create a new arena
specifically for this object. That arena is stored in localArena. When the
object is destroyed, any localArena's will be freed.