1629776 - Parent with overflow hidden and border-radius don't hide overflowed child content

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[vytya]

Attachment: Screenshot_2.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Open this link https://codepen.io/jh3y/pen/aQomdd

Actual results:

Overflowed child content are not hiding

Expected results:

Overflowed child content should hide

Comment 1

[Alice0775 White]

The glitch appears if WebRender is enabled.

Comment 2

[Miko Mynttinen]

Regressed by bug 1617879.

Comment 3

[Miko Mynttinen]

Attachment: transform-clip.html

Simplified testcase.

Comment 4

[Miko Mynttinen]

This might be a problem that Gecko avoids by not transforming clip rects1.

Comment 5

[Alice0775 White]

(FWIW, if you change the zoom level, it will be displayed correctly at certain zoom level.)

Comment 6

[Dzmitry Malyshau [:kvark]]

Attachment: clip-round.yaml

YAML test case

Comment 7

[Dzmitry Malyshau [:kvark]]

Attachment: Handle WR case of an empty inner transformed rectangle

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc07e446ee6c
Handle WR case of an empty inner transformed rectangle r=gw

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cc07e446ee6c

Comment 10

[Dzmitry Malyshau [:kvark]]

Comment on attachment 9141098 [details]
Handle WR case of an empty inner transformed rectangle

Beta/Release Uplift Approval Request

• User impact if declined: Broken rendering on some of the websites.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very minor change, mostly tests.
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141098 [details]
Handle WR case of an empty inner transformed rectangle

Fixes a WR regression in 76. Approved for 76.0b6.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a8ac6c9e5b2