Closed Bug 1629776 Opened 4 years ago Closed 4 years ago

Parent with overflow hidden and border-radius don't hide overflowed child content

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
75 Branch
Platform:
x86_64
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- fixed
firefox77 --- fixed

People

(Reporter: sagidulin, Assigned: kvark)

References

(Regression)

Details

(Keywords: regression, testcase)

Attachments

(4 files)

Screenshot_2.png
11.11 KB, image/png
Details
transform-clip.html
512 bytes, text/html
Details
clip-round.yaml
613 bytes, application/x-yaml
Details
Handle WR case of an empty inner transformed rectangle
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Attached image Screenshot_2.png —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Open this link https://codepen.io/jh3y/pen/aQomdd

Actual results:

Overflowed child content are not hiding

Expected results:

Overflowed child content should hide

OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64

The glitch appears if WebRender is enabled.

Status: UNCONFIRMED → NEW
Component: Untriaged → Graphics: WebRender
Ever confirmed: true
Product: Firefox → Core

Regressed by bug 1617879.

Has Regression Range: --- → yes
Flags: needinfo?(dmalyshau)
Keywords: regression, testcase
Regressed by: 1617879
Priority: -- → P3
Attached file transform-clip.html —

Simplified testcase.

This might be a problem that Gecko avoids by not transforming clip rects1.

(FWIW, if you change the zoom level, it will be displayed correctly at certain zoom level.)

Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED
Flags: needinfo?(dmalyshau)
Attached file clip-round.yaml —

YAML test case

Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc07e446ee6c
Handle WR case of an empty inner transformed rectangle r=gw

https://hg.mozilla.org/mozilla-central/rev/cc07e446ee6c

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Comment on attachment 9141098 [details]
Handle WR case of an empty inner transformed rectangle

Beta/Release Uplift Approval Request

  • User impact if declined: Broken rendering on some of the websites.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very minor change, mostly tests.
  • String changes made/needed:
Attachment #9141098 - Flags: approval-mozilla-beta?

Comment on attachment 9141098 [details]
Handle WR case of an empty inner transformed rectangle

Fixes a WR regression in 76. Approved for 76.0b6.

Attachment #9141098 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: