1629781 - Cannot run WPT on Windows due to `TypeError: unhashable type: 'dict'`

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I try to run a WPT test locally on my Win10 environment, but I cannot do it due to the following error:

TypeError: unhashable type: 'dict'

  File "m:\src\testing/web-platform/mach_commands.py", line 369, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "m:\src\testing/web-platform\mach_commands_base.py", line 44, in run
    result = wptrunner.start(**kwargs)
  File "m:\src\testing/web-platform/tests/tools/wptrunner\wptrunner\wptrunner.py", line 383, in start
    rv = not run_tests(**kwargs) or logged_critical.has_log
  File "m:\src\testing/web-platform/tests/tools/wptrunner\wptrunner\wptrunner.py", line 242, in run_tests
    logger.suite_start(test_source_cls.tests_by_group(tests, **test_source_kwargs),
  File "m:\src\testing/web-platform/tests/tools/wptrunner\wptrunner\testloader.py", line 379, in tests_by_group
    return {cls.group_metadata(None): [t.id for t in tests]}

The function tests_by_group was added by bug 1614643.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Once I back out the patch, I can run WPT.

Comment 2

[Andrew Halberstadt [:ahal]]

My apologies, I tested locally but I guess I used the chunking arguments so never hit this code path.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1629781 - [wpt] Fix regression to './mach web-platform-tests' without chunking args, r?jgraham

Fixes a regression caused by bug 1614643.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f943eab2344
[wpt] Fix regression to './mach web-platform-tests' without chunking args, r=jgraham

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7f943eab2344

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23114 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot