1629901 - [False Negative] Password generation is not offered for new password field on sogou.com

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Andrei Purice]

Affected Versions:
Nightly 77.0a1 (2020-04-14) (64-bit)
Beta 76.0b4

Affected Platforms:
Windows 7/10 x64
MacOS 10.14
Ubuntu 18.04

Steps to reproduce:

1. Go to https://www.sogou.com/ and reach the Register account form
2. Click on the New Password field from the site

Expected Result:
The autocomplete dropdown should be displayed for the New Password field with the Password Generation option

Actual Result:
Password Generation was not offered for the New Password field

Regression-Range:
Not a regression - doesn't work in Beta 75.

Notes:
Password field: <input type="password" id="password_input" value="请输入密码" class="grey" style="width: 302px; display: none;">

Comment 1

[Bianca Danforth [:bdanforth]]

According to its Tranco + Alexa ranking, this site is among the most popular (which we are currently defining to be the top 500).

Comment 2

[Matthew N. [:MattN]]

Erik is working on a model update to potentially address this.

Comment 3

[:severin Rudie]

Will be fixed by code landing in bug 1638187.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Weirdly enough, password generation appears intermittently. I have 2 different tabs opened with the same registration form and it appears only on the first one. Attaching logs from case where it appears and when it doesn't, the cases where it doesn't have the following log:

LoginAutoComplete: Hiding footer: non-empty password field LoginAutoComplete.jsm:291:11

Comment 5

[Timea Cernea [:tbabos][inactive]]

Attachment: Password Generation appears

Comment 6

[Timea Cernea [:tbabos][inactive]]

Attachment: Doesn't Appear

Comment 7

[:severin Rudie]

This one's failing pretty regularly, I think we should keep it open until we have a chance to take a look into it.

Debugging note: MattN and I checked briefly today, and it looks like it's using a non-standard pattern for displaying placeholder text. Rather than using the placeholder attribute, it has two overlapping input fields and swaps which one is displayed based on focus and user input. There's probably a race condition in here somewhere that sometimes causes us to miss the actual password input while it's display: none.

Comment 8

[Matthew N. [:MattN]]

Bumping down to P2 since although this is a popular website, the issue is a false negative, not a false positive and the user can use the context menu as a fallback.

Comment 9

[Sergey Galich [:serg]]

Moving to P3 as this is not happening in the next release cycle.