1629936 - Investigate if our pref flipping code is doing what we want

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, task, P3)

Description

[Jessie [:jbonisteel] pls NI]

Following up from our conversation on Riot, it seems like the pref flipping code around WebRender may not always do what we want it do. Copying some of that convo here:

HasAcceleratedLayers doesn't check for WR for one, and two status is always non-zero (FEATURE_OK, FEATURE_BLOCKED_*, etc are all non-zero values)

Should that check for WR?

yup, but it should also check if the feature is allowed too. might be better ways to check as well, because even if the blocklist says it is okay, you still might not get the feature :)
I think it always passes right now though

So purpose of this task is to make sure we are doing what we intend to do.

Comment 1

[Jessie [:jbonisteel] pls NI]

Jeff, Andrew - can we determine what, if any, changes we should make here?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Andrew can you put up a patch to fix the issue you saw?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1629936 - Fix how we would never disable WebGL due to no hardware compositing.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa94f8ddb9b50f90e7c7c9ef857ad59196d8177a

Comment 5

[Glenn Watson [:gw]]

Probably no longer relevant.