Open Bug 1629936 Opened 2 years ago Updated 5 months ago

Investigate if our pref flipping code is doing what we want

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

People

(Reporter: jbonisteel, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

Following up from our conversation on Riot, it seems like the pref flipping code around WebRender may not always do what we want it do. Copying some of that convo here:

HasAcceleratedLayers doesn't check for WR for one, and two status is always non-zero (FEATURE_OK, FEATURE_BLOCKED_*, etc are all non-zero values)

Should that check for WR?

yup, but it should also check if the feature is allowed too. might be better ways to check as well, because even if the blocklist says it is okay, you still might not get the feature :)
I think it always passes right now though

So purpose of this task is to make sure we are doing what we intend to do.

Jeff, Andrew - can we determine what, if any, changes we should make here?

Flags: needinfo?(jmuizelaar)
Flags: needinfo?(aosmond)
See Also: → 1627432
Blocks: wr-intro
Priority: -- → P3
Blocks: wr-76

Andrew can you put up a patch to fix the issue you saw?

Flags: needinfo?(jmuizelaar)
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Blocks: wr-78
No longer blocks: wr-76
Blocks: wr-79
No longer blocks: wr-78
Flags: needinfo?(aosmond)
No longer blocks: wr-79
Blocks: wr-81
No longer blocks: wr-80
Blocks: gfx-83
No longer blocks: wr-81
Blocks: gfx-triage
No longer blocks: gfx-83
No longer blocks: gfx-triage
Attachment #9152195 - Attachment is obsolete: true
Assignee: aosmond → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.