1629955 - Crash if Navigator.gpu returns NULL

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P3)

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Don't fail WebGPU Instance creation

we can't fail at Navigator.gpu
Instead, we reject the promise of requestAdapter

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a5289dab0b
Don't fail WebGPU Instance creation r=jgilbert

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e2a5289dab0b

Comment 4

[Dzmitry Malyshau [:kvark]]

Comment on attachment 9140498 [details]
Don't fail WebGPU Instance creation

Beta/Release Uplift Approval Request

• User impact if declined: GPU process crash when trying to run WebGPU content, see bug 1612523
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's technically covered by dom/webgpu/mochitest/test_disabled.html, although I'm not sure why it wasn't crashing there. Will look into that!
  The change here is low risk, because it changes the logic that's already crashing, in a minor way.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9140498 [details]
Don't fail WebGPU Instance creation

Avoids a crash when WebGPU is disabled. Approved for 76.0b7.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81a361aa33b9