The two "new tab" buttons have different accessible label
Categories
(Firefox :: Tabbed Browser, defect, P3)
Tracking
()
| Accessibility Severity | s4 |
People
(Reporter: cwendling, Unassigned, Mentored)
References
Details
(Keywords: access)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
Get the accessible name of the 2 "New tab" buttons (the one when there are "few" tabs, and the one when there are "many" tabs)
Actual results:
They have a different label. The "few" tabs one states "Open a new tab (Ctrl+T)", and the "many" tabs one states "New tab".
Expected results:
Both buttons which provide the exact same feature and apparently are only different buttons for internal reasons should have the same label to improve consistency and avoid confusion. This affects users of assistive technologies like screen readers.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1628360#c14
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
Resetting severity to default of --.
|
||
Comment 2•5 years ago
|
||
Updating the Accessibility Team's impact assessment to conform with the new triage guidelines. See https://wiki.mozilla.org/Accessibility/Triage for descriptions of these whiteboard flags.
|
|
||
Comment 3•5 years ago
|
||
Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)
|
||
Updated•1 years ago
|
|
||
Comment 4•1 year ago
|
||
:cmkm, Can you confirm with the l10n folks what the best plan is to resolve this and write it up for a potential good-first-bug contributor?
Would you be able to see if this still reproduces for you, Sam? I wasn't able to repro, and it sounds like this might be an a11y bug instead?
|
|
||
Comment 6•11 months ago
|
||
For the not-many-tabs case, we see #tabs-newtab-button
For the many tab (tab strip overflowed) case, we see #new-tab-button
Both seem to produce the same tooltip, but I'm not sure that is the same as the accessible name.
In the tabs-newtab-button case, that element has a .ariaLabel of "Open a new tab (Ctrl+T)". It has no dataset.l10nId, but sets this label programatically in the MozBrowserTabs init function.
In the case of new-tab-button, it has .ariaLabel of null and .label of "New Tab", via the tabs-toolbar-new-tab l10nId.
I'm afraid I don't know the history of why these 2 buttons are implemented so differently. But yes, the difference does seem to exist, and should be easy enough to fix - we just need to decide which treatment to apply to both buttons.
Description
•