Irregexp: Call regexps from Ion
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
References
Details
Attachments
(2 files)
Bug 1628835 and bug 1629670 handle interpreting and compiling regexps. The last major piece of the puzzle is calling them from Ion (and Warp).
|
Assignee | |
Comment 1•4 years ago
|
||
PrepareAndExecuteRegexp has to be updated to call the new engine. In preparation, this patch factors out a couple of helper functions that a) can be shared between the two versions, and b) make sense as standalone functions in the future when we remove the old implementation.
|
|
Assignee | |
Comment 2•4 years ago
|
||
The code in this patch lines up fairly closely with the old version of PrepareAndExecuteRegexp, but not so closely that I wanted to unify them, particularly since the old version will be going away. Aside from the changes to the layout of the input data, the main difference is that the return value is now being passed in a register instead of on the stack.
Depends on D71080
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7efbecf663a8 Refactor PrepareAndExecuteRegexp r=jandem https://hg.mozilla.org/integration/autoland/rev/fe4b1b625e77 Implement PrepareAndExecuteRegexp for new engine r=jandem
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7efbecf663a8
https://hg.mozilla.org/mozilla-central/rev/fe4b1b625e77
Description
•