1630221 - Raw header toggle does not change color when checked

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

The :checked color is overridden by https://searchfox.org/mozilla-central/rev/72e3388f74458d369af4f6cdbaeaacb719523b8c/devtools/client/netmonitor/src/assets/styles/NetworkDetailsBar.css#307 and as a result it always stay grey.

there's no point doing that as the original style take care of this https://searchfox.org/mozilla-central/rev/72e3388f74458d369af4f6cdbaeaacb719523b8c/devtools/client/themes/common.css#776,808

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1630221 - Fix netmonitor toggle input checked styling. r=Honza.

The toggle style was overridden in netmonitor for
no obvious reason, as the base styles take care of
everything we need.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/416295247faf
Fix netmonitor toggle input checked styling. r=Honza.

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/416295247faf

Comment 5

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Hi Nicolas, is there something that QA can help with here? And if so, are there any STR for this? Thanks!

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: screenshot_with_fix_applied

Sure.
You can:

1. open the netmonitor
2. reload the page if there isn't any requests logged
3. select a request
4. Select the headers panel
5. On the Response headers section title, click on the Raw header toggle

-> when enabled, the toggle background should be blue, as it is in the screenshot I uploaded

Comment 7

[Cristian Fogel [:cfogel]]

Reproduced the issue with 77.0a1 (2020-04-15).
Verified fix with 77.0b2.