Closed Bug 163024 Opened 22 years ago Closed 22 years ago

bugzilla_email_append.pl calls processmail incorrectly

Categories

(Bugzilla :: Bugzilla-General, defect, P1)

Product:
Bugzilla
Component:
Bugzilla-General
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

(Whiteboard: [fixed in 2.16.1] [fixed in 2.14.4] [fixed on trunk])

Attachments

(1 file)

patch
696 bytes, patch
bugreport
: review+
preed
: review+
Details | Diff | Splinter Review 
 
Bleh. Stupid enter key...

Anyway, as jussi pointed out in bug 160631, bugzilla_email_append.pl uses the
same quoting that bug_email.pl used, which was fixed for bug 154008:

system("cd .. ; ./processmail $found_id '$SenderShort'");

is not the way to go. We should fix that....
Severity: normal → critical
Priority: -- → P1
Whiteboard: [want for 2.16.1]
Target Milestone: --- → Bugzilla 2.18
Attached patch patch — — Splinter Review 
This patch WFM. (modulo the usual bug_email bugs)
What happened to "cd .."?

Gerv
Its not needed since bug 154008 went in - ie this is another breakage from that.
Assignee: justdave → bbaetz
Keywords: patch, review
Comment on attachment 95666 [details] [diff] [review]
patch


r=joel assuming that someone has confirmed that the routined still does its
desired function.
Still need a seperate 2xr for 2.16 branch.
Attachment #95666 - Flags: review+
Comment on attachment 95666 [details] [diff] [review]
patch

People still use this stuff?!

Wild.

r2=preed
Attachment #95666 - Flags: review+
Yes, people still use this (unfortunately)

Checked in to trunk and 2.16/2.14 branches
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: [want for 2.16.1] → [fixed in 2.16.1] [fixed in 2.14.4] [fixed on trunk]
Removing security bit for publication in status report.
Group: webtools-security?
Err... Weren't we waiting for 2.16.1 before removing the sceuirity bit? Readding
the security bit for now....
Group: webtools-security?
Security Announcement is posted.  removing the security bit.
Group: webtools-security?
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.