Closed Bug 1630323 Opened 5 months ago Closed 4 months ago

Do not override user preferences when clicking on a service worker notification to open a new document

Categories

(Core :: DOM: Service Workers, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- fixed

People

(Reporter: annyG, Assigned: annyG)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → agakhokidze
Status: NEW → ASSIGNED
Regressed by: 1622749
Priority: -- → P2
Attached file Bug 1630323 - WIP (obsolete) —
Attachment #9141055 - Attachment is obsolete: true
Attachment #9143784 - Attachment description: Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document → Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r?Gijs!

NeedInfo'ing Andrew on this as I need help answering one of the review comments.

Some backstory:
The need for this bug stemmed out of my hacky solution for crash happening in bug 1622749 (the crash was happening in code landed in bug 1578070).

I have a patch above with hopefully a complete description of how the crash came to be and how I’m trying to fix the regression properly instead of the hacky solution.

I was wondering you could help me answer Gij’s questions in the one comment linked here https://phabricator.services.mozilla.com/D72745#inline-427631 ? Is it a problem that WaitForLoad will be invoked via event loop now? If not, I guess I could dispatch a runnable (calling WaitForLoad) to the proper thread in the resolve case of the promise somehow… I’m also not sure about the second question - is it possible that the load succeeds before WaitForLoad?

Flags: needinfo?(bugmail)

Responded on the review, with the caveat that I would likely consider :nika and :smaug as likely to have more authoritative guidance about the load edge cases.

Flags: needinfo?(bugmail)
Attachment #9143784 - Attachment description: Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r?Gijs! → Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r?Gijs!,nika!
Attachment #9146666 - Attachment is obsolete: true
Attachment #9143784 - Attachment description: Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r?Gijs!,nika! → Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r?Gijs!,nika!,snorp!
Pushed by agakhokidze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0de352a865b
Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.