1630337 - Twisty icons are cut off in the buddy list sidebar

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2020-04-15 10-25-26.png

After the update of the twisty from m-c, the size of those icons don't match the container anymore.
Since we're using that SVG as a background image, this can be easily fixed with a background-size: contain property.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: conversation-twisty.diff

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: conversation-twisty.diff

Small typo in the commit message.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9140812 [details] [diff] [review]
conversation-twisty.diff

Review of attachment 9140812 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: mail/components/im/themes/chat.css
@@ +752,5 @@
>  
>  /* from instantbird/themes/blist.css */
>  richlistitem[is="chat-group-richlistitem"] .twisty {
>    padding-top: 1px;
> +  width: 10px; /* The image's width is 8 pixels */

The width is now 10 pixels. Or remove the comment because the image (twisty-*.svg) width is 12px in reality.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: conversation-twisty.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb41490f1491
Fix twisty icon size in chat conversation richlist. r=Paenglab