Closed
Bug 1630380
Opened 5 years ago
Closed 4 years ago
When autofilling logins with empty username fields, username boxes should not be highlighted
Categories
(Toolkit :: Password Manager, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | verified |
People
(Reporter: severin, Assigned: severin)
References
Details
Attachments
(2 files)
Highlighting input elements when they are autofilled is used to communicate to the user that we have made a change to it. When the saved login username is blank, we are not making any change to the element, so highlighting it is confusing. In the worst case users might (erroneously) believe that we have blanked the field.
Steps to reproduce:
- On any site we are capable of autofilling on
- Save a login with a password, but with an empty username field
- Refresh page
Expected:
- Password field is filled in and higlighted
- Username field is unchanged
Actual:
- Password field is filled in and highlighted
- Username field is highlighted
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → severin.mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Attachment #9141451 -
Attachment description: Bug 1630380 - pass manager shouldn't fill/highlight blank usernames. r=MattN → Bug 1630380 - pass manager shouldn't highlight blank usernames. r=MattN
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/23cf5c8c6f41
pass manager shouldn't highlight blank usernames. r=MattN
Comment 3•4 years ago
|
||
Backed out changeset 23cf5c8c6f41 (bug 1630380) for causing browser_basicAuth_switchTab.js failures
https://hg.mozilla.org/integration/autoland/rev/10633b1542b37ec4570f770e34b24d2ef29f9ead
log: https://treeherder.mozilla.org/logviewer.html#?job_id=298532390&repo=autoland
Flags: needinfo?(severin.mozilla)
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b2db14f0dde
pass manager shouldn't highlight blank usernames. r=MattN
Comment 6•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Comment 7•4 years ago
|
||
Verified-fixed on latest Nightly 77.0a1 (2020-04-27) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•