1630380 - When autofilling logins with empty username fields, username boxes should not be highlighted

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[:severin Rudie]

Attachment: highlighted-empty-username.png

Highlighting input elements when they are autofilled is used to communicate to the user that we have made a change to it. When the saved login username is blank, we are not making any change to the element, so highlighting it is confusing. In the worst case users might (erroneously) believe that we have blanked the field.

Steps to reproduce:

• On any site we are capable of autofilling on
• Save a login with a password, but with an empty username field
• Refresh page

Expected:

• Password field is filled in and higlighted
• Username field is unchanged

Actual:

• Password field is filled in and highlighted
• Username field is highlighted

Comment 1

[:severin Rudie]

Attachment: Bug 1630380 - pass manager shouldn't highlight blank usernames. r=MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23cf5c8c6f41
pass manager shouldn't highlight blank usernames. r=MattN

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 23cf5c8c6f41 (bug 1630380) for causing browser_basicAuth_switchTab.js failures
https://hg.mozilla.org/integration/autoland/rev/10633b1542b37ec4570f770e34b24d2ef29f9ead

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-3%2Cm-fis%28bc3%29&fromchange=13ce97c56e6e78fef17472ff86cd5a9805a13a5a&tochange=0affade618e1c7b0343356c61d37057868c6bd30&selectedJob=298532390

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298532390&repo=autoland

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b2db14f0dde
pass manager shouldn't highlight blank usernames. r=MattN

Comment 5

[Andrei Ciure[:aciure]]

Disregard the backout.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0b2db14f0dde

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Nightly 77.0a1 (2020-04-27) on Windows 10, MacOS 10.13 and Ubuntu 16.04.