Closed Bug 1630413 Opened 4 years ago Closed 4 years ago

remove unlimitedStorage prompting


(WebExtensions :: General, enhancement, P1)



(Not tracked)



(Reporter: mixedpuppy, Assigned: mixedpuppy)


(Blocks 1 open bug)


(Keywords: dev-doc-complete)


(1 file, 1 obsolete file)

No description provided.
Priority: -- → P1
Assignee: nobody → mixedpuppy

Since we have code to test the removal of the permission on addon upgrade, I'm presuming that we're good to go. However, it might be good to know what, if any, issues there are with removing the peristed storage. Andrew, any thoughts on that?

Flags: needinfo?(bugmail)

So, bug 1558478 applies in that once persistent-storage is granted to an origin, it's currently forever granted unless you wipe the data for the origin. I'm not sure there's practically anything you can do about that other than wiping the origin instead of removing the permission. This sounds somewhat user hostile though. Taking the action of removing the permission should be sufficient for QuotaManager to auto-correct in the future, though.

Flags: needinfo?(bugmail)
See Also: → 1558478
Attachment #9141137 - Attachment is obsolete: true
Summary: make unlimitedStorage an optional permission → remove unlimitedStorage prompting
Pushed by
don't prompt for unlimitedStorage extension permission r=rpl
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

To confirm, the documentation changes needed are to state that this permission is now optional?

Flags: needinfo?(mixedpuppy)

The permission is optional AND there is no permission warning any more (see comment 5).

Flags: needinfo?(mixedpuppy)

(In reply to Rob Wu [:robwu] from comment #9)

The permission is optional AND there is no permission warning any more (see comment 5).

It is not optional, but we do not prompt for it at this time to allow addons to update without interruption. It will eventually move to optional, and we'll may re-introduce the prompt at that time.

Given that, I'm not certain we need to make a change unless there is anything that states it will be in the permission prompt at install.

There is mention of the prompting from unlimitedStorage on the Extension Workshop page Requesting the right permissions and an appropriate change has been submitted in Removal of unlimitedStorage prompting #633. The release notes have also been updated. Please let me know if you think there should be any further changes.

Flags: needinfo?(mixedpuppy)


Flags: needinfo?(mixedpuppy)
You need to log in before you can comment on or make changes to this bug.