1630413 - remove unlimitedStorage prompting

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1630413 support unlimitedStorage as an optional extension permission

Comment 2

[Shane Caraveo (:mixedpuppy)]

Since we have code to test the removal of the permission on addon upgrade, I'm presuming that we're good to go. However, it might be good to know what, if any, issues there are with removing the peristed storage. Andrew, any thoughts on that?

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

So, bug 1558478 applies in that once persistent-storage is granted to an origin, it's currently forever granted unless you wipe the data for the origin. I'm not sure there's practically anything you can do about that other than wiping the origin instead of removing the permission. This sounds somewhat user hostile though. Taking the action of removing the permission should be sufficient for QuotaManager to auto-correct in the future, though.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1630413 don't prompt for unlimitedStorage extension permission

Comment 5

[Rob Wu [:robwu]]

Needs to be updated:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/local
https://extensionworkshop.com/documentation/develop/request-the-right-permissions/

and maybe also
https://support.mozilla.org/en-US/kb/permission-request-messages-firefox-extensions#w_store-unlimited-amount-of-client-side-data

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d7dd79ef9ec
don't prompt for unlimitedStorage extension permission r=rpl

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4d7dd79ef9ec

Comment 8

[Richard Bloor]

To confirm, the documentation changes needed are to state that this permission is now optional?

Comment 9

[Rob Wu [:robwu]]

The permission is optional AND there is no permission warning any more (see comment 5).

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Rob Wu [:robwu] from comment #9)

The permission is optional AND there is no permission warning any more (see comment 5).

It is not optional, but we do not prompt for it at this time to allow addons to update without interruption. It will eventually move to optional, and we'll may re-introduce the prompt at that time.

Given that, I'm not certain we need to make a change unless there is anything that states it will be in the permission prompt at install.

Comment 11

[Richard Bloor]

There is mention of the prompting from unlimitedStorage on the Extension Workshop page Requesting the right permissions and an appropriate change has been submitted in Removal of unlimitedStorage prompting #633. The release notes have also been updated. Please let me know if you think there should be any further changes.

Comment 12

[Shane Caraveo (:mixedpuppy)]

thanks!