Closed Bug 1630425 Opened 5 years ago Closed 4 years ago

Link webrtc-gtest only as needed, like xul-gtest

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1634675

People

(Reporter: away, Unassigned)

References

(Blocks 1 open bug)

Details

webrtc-gtest takes a long time to link in LTO builds. As far as I can tell, nothing in CI actually invokes that binary. Does it only exist for developers to do mach webrtc-gtest locally?

Naively, I tried the same output_category=None if CONFIG['LINK_GTEST_DURING_COMPILE'] else 'gtest' trick as xul-gtest, but it didn't work because webrtc-gtest is a program, and the output_category stuff is plumbed pretty deeply to be specific to shared libraries. At this point this is exceeding my build-fu...

See Also: → 1630523
Priority: -- → P3

Yes, this is only used for local development. Actually, I don't think it is used very much at all, so we might be able to just remove it from the build. I think it is leftover from a time when we used to make a lot of local changes to webrtc.org code. I'm asking around to see if anyone objects.

See Also: → 1634675
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.