1630428 - Tons of boilerplate for updating WR resources

Status: NEW

(Core :: Graphics: WebRender, defect, P3)

Description

[Dzmitry Malyshau [:kvark]]

Was just adding a new method to request an external image update from the content side, and I'm looking at many different source files essentially expressing the same logic:

• IpcResourceUpdateQueue::UpdatePrivateExternalImage (h + cpp)
• WebRenderMessages.ipdlh
• WebRenderBridgeParent::UpdateResources switch case
• WebRenderBridgeParent::UpdatePrivateExternalImage (h + cpp signature)

Then it goes into WR land with a more generic update_external_image function. It's not nearly as bad, since in Rust at least you don't have to repeat the signature (h/cpp separation). But there is some (necessary?) repetition still:

• TransactionBuilder::UpdateExternalImageWithDirtyRect (h + cpp)
• wr_resource_updates_update_external_image_with_dirty_rect (bindings.rs)
• Transaction::update_image
• enum ResourceUpdate::UpdateImage variant

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Did anything jump as you as a good thing to get rid of/fix?

Comment 2

[Dzmitry Malyshau [:kvark]]

Nothing jumped at me as an easy target to address.