Closed Bug 1630506 Opened 4 months ago Closed 4 months ago

Reduce the address bar's drop shadow when it's focused but not open

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox76 --- verified
firefox77 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This would help with the bookmarks toolbar.

Priority: -- → P2
Points: --- → 1
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 77.1 - Apr 6 - Apr 19
Iteration: 77.1 - Apr 6 - Apr 19 → 77.2 - Apr 20 - May 3
Flags: qe-verify+
Keywords: blocked-ux
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19cd1497d0c7
Reduce the address bar's drop shadow when it's focused but not open. r=harry
Summary: Consider reducing the address bar's drop shadow when it's focused but not open → Reduce the address bar's drop shadow when it's focused but not open

Comment on attachment 9140978 [details]
Bug 1630506 - Reduce the address bar's drop shadow when it's focused but not open.

Beta/Release Uplift Approval Request

  • User impact if declined: Users have complained about how the megabar overlaps the bookmarks toolbar. See bug 1628243. Part of this was actual overlap, another part was the bookmarks buttons being small targets to hit to start with, and the last part is the drop shadow the address bar casts over the bookmarks toolbar which is purely a visual effect. This patch addresses that last part.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
    1. open a new tab (address bar is focused)
    2. press the down arrow to open the top sites dropdown
      Step 1 should give the address bar a smaller drop shadow than step 2.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial CSS-only fix
  • String changes made/needed:
Attachment #9140978 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
QA Whiteboard: [qa-triaged]

Verified as fixed using latest Nightly 77.0a1 2020-04-23 under Win 10 64-bit, Mac OS X 10.14 and Ubuntu 18.04 64-bit.

== Change summary for alert #25699 (as of Fri, 24 Apr 2020 00:48:49 GMT) ==

Improvements:

3% tart linux64-shippable opt e10s stylo 2.04 -> 1.98
3% startup_about_home_paint_realworld_webextensions linux64-shippable opt e10s stylo 809.67 -> 787.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25699

See Also: → 1617101

Comment on attachment 9140978 [details]
Bug 1630506 - Reduce the address bar's drop shadow when it's focused but not open.

Minor megabar visual tweak. Approved for 76.0rc1.

Attachment #9140978 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Target Milestone: Firefox 77 → Firefox 76

Target milestone reflects when a change landed on mozilla-central.

Target Milestone: Firefox 76 → Firefox 77

Verified as fixed using 76.0RC under Win 10 64-bit and Mac OS X 10.14 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.