1630506 - Reduce the address bar's drop shadow when it's focused but not open

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Dão Gottwald [:dao]]

This would help with the bookmarks toolbar.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1630506 - Reduce the address bar's drop shadow when it's focused but not open.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19cd1497d0c7
Reduce the address bar's drop shadow when it's focused but not open. r=harry

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9140978 [details]
Bug 1630506 - Reduce the address bar's drop shadow when it's focused but not open.

Beta/Release Uplift Approval Request

• User impact if declined: Users have complained about how the megabar overlaps the bookmarks toolbar. See bug 1628243. Part of this was actual overlap, another part was the bookmarks buttons being small targets to hit to start with, and the last part is the drop shadow the address bar casts over the bookmarks toolbar which is purely a visual effect. This patch addresses that last part.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  1. open a new tab (address bar is focused)
  2. press the down arrow to open the top sites dropdown
     Step 1 should give the address bar a smaller drop shadow than step 2.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS-only fix
• String changes made/needed:

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/19cd1497d0c7

Comment 5

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using latest Nightly 77.0a1 2020-04-23 under Win 10 64-bit, Mac OS X 10.14 and Ubuntu 18.04 64-bit.

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #25699 (as of Fri, 24 Apr 2020 00:48:49 GMT) ==

Improvements:

3% tart linux64-shippable opt e10s stylo 2.04 -> 1.98
3% startup_about_home_paint_realworld_webextensions linux64-shippable opt e10s stylo 809.67 -> 787.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25699

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9140978 [details]
Bug 1630506 - Reduce the address bar's drop shadow when it's focused but not open.

Minor megabar visual tweak. Approved for 76.0rc1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/172988f10e48

Comment 9

[Dão Gottwald [:dao]]

Target milestone reflects when a change landed on mozilla-central.

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Verified as fixed using 76.0RC under Win 10 64-bit and Mac OS X 10.14 and Ubuntu 18.04.