1630661 - No webaudio data in PGO profiles

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[(Away)]

While watching a PGO training build on my machine I noticed that the webaudio page isn't actually doing anything. I think one of the recent changes made it depend on "raptor" in the URL to auto-start.

I tried adding "raptor" and then we were back to having speex functions swamping the profiles, so I'll also reduce the duration...

Comment 1

[(Away)]

Attachment: Fix webaudio querystring to autostart for PGO

One of the recent changes made it so that the test doesn't start on its own unless the URL has "raptor".

I've confirmed that this

• Does not swamp out the profdata file
• Does not regress displaylist-mutate
• Improves the webaudio score

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e2f190bf603
Fix webaudio querystring to autostart for PGO r=padenot

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4e2f190bf603

Comment 4

[Florin Strugariu [:Bebe]]

== Change summary for alert #25646 (as of Fri, 17 Apr 2020 07:03:08 GMT) ==

Improvements:

15% raptor-webaudio-firefox macosx1014-64-shippable opt 196.42 -> 167.92
14% raptor-webaudio-firefox windows10-64-shippable opt 173.83 -> 150.33
13% raptor-webaudio-firefox windows10-64-shippable-qr opt 172.08 -> 150.25
12% raptor-webaudio-firefox windows7-32-shippable opt 193.17 -> 169.67
11% raptor-webaudio-firefox linux64-shippable opt 152.42 -> 135.83
10% raptor-webaudio-firefox linux64-shippable-qr opt 157.75 -> 142.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25646

Comment 5

[(Away)]

Comment on attachment 9141027 [details]
Fix webaudio querystring to autostart for PGO

Beta/Release Uplift Approval Request

• User impact if declined: Slower webaudio code. The webaudio code was accidentally removed from PGO training in bug 1625912, which has since made it to beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch adds back a test to the PGO training set that previously used to be there.
• String changes made/needed: no

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141027 [details]
Fix webaudio querystring to autostart for PGO

Re-add webaudio to the PGO training set. Approved for 76.0b7.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e0139f8bd40