Closed Bug 1630715 Opened 5 years ago Closed 5 years ago

"Restart to update Firefox" button should use title case to match rest of buttons in prefs window.

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 77
Tracking Status
firefox77 --- verified

People

(Reporter: rachel, Assigned: mkohler)

Details

Attachments

(2 files)

It looks particularly off since there's a button right above it that capitalizes the word "Update" ("Show Update History").

Looking at the rest of the buttons in settings, it seems that we're title casing them; guessing maybe this one just got missed since it's shown dynamically.

Summary: "Restart to update Firefox" button should use title case to make rest of buttons in prefs window. → "Restart to update Firefox" button should use title case to match rest of buttons in prefs window.

I think the difference here is that in "Show Update History", "Update History" is a proper noun, whereas in "Restart to update Firefox", "update" is a verb. I looked through the other buttons in preferences and I don't see any other buttons that have verbs in them. I'm okay with leaving this as-is.

I'll flag Meridel just to double check.

Flags: needinfo?(mwalkington)

Yes, the button should be title case: Restart to Update Firefox

We should be using title case for the first letter of nouns, adjectives, verbs, adverbs, and pronouns: https://design.firefox.com/photon/copy/capitalization.html

Thanks for catching that, Rachel.

Flags: needinfo?(mwalkington)
Assignee: nobody → me
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c091dd210b99 Update restart button in preferences to use title case r=jaws,fluent-reviewers
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
Flags: qe-verify+

Reproduced the initial issue using Nightly build 77.0a1 (build id: 20200416214356).
Verified - Fixed in Beta 77.0b2 and Nightly 78.0a1 (build id: 20200507085231) on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: