1630754 - [Wayland] Explicitly configure wayland display for VA-API video playback

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Right now we don't set VADisplay but use av_hwdevice_ctx_create() to create vaapi device without display.

Some drivers (intel ironlake in my case) fails to pick up Wayland display but creates va-api device on top of X11 one which leads to HW playback failure.

As a solution let's create VADisplay explicitly on top of our wayland display connection.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1630754 [Wayland][VA-API] Explicitly configure VADisplay display for VA-API video playback, r?jya

Some gfx drivers (especially on a child process) can open X11 VADisplay instead of a Wayland one which leads
to HW playback failure. As a solution let's create VADisplay explicitly on top of our wayland display connection.

• Load vaGetDisplayWl from libva-wayland.so
• Explicitly create VADisplay at CreateVAAPIDeviceContext()
• Use VAAPIDisplayHolder class to release our VADisplay when AVHWDeviceContext is released (by hwctx->free).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c159181ff5d0
[Wayland][VA-API] Explicitly configure VADisplay display for VA-API video playback, r=jya

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c159181ff5d0