1630828 - macOS Control-left-clicks on bookmark pop-ups follow the bookmark (instead of showing context menu)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Brad Werth [:bradwerth]]

Steps to Reproduce:

1. Ensure that View -> Toolbars -> Bookmarks Toolbar is on.
2. Add a bookmark folder to the Bookmark Toolbar. It can be "New Folder".
3. Add a bookmark or move a bookmark into the New Folder.
4. Click on the New Folder, displaying the pop-up bookmark menu.
5. Hold down Control key and left-click on the bookmark added in Step 3.

Expected Results:
A context menu appears, starting with "Open in a New Tab".

Actual Results:
Context menu appears briefly, then disappears, and the browser navigates to the bookmark.

Comment 1

[Edgar Chen [:edgar]]

Thanks for catching this bug, I will take a look.

Comment 2

[Edgar Chen [:edgar]]

Filed bug 1630959 as a follow-up to check other places that possibly also need a tweak.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1630828 - Handle mouseup properly on Mac when ctrl key is pressed;

On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to handle onclick when ctrl key is pressed.

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c2ff01e5ae8824bab864c57aeee05ed02486e90

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d3a1a9c05bd
Handle mouseup properly on Mac when ctrl key is pressed; r=NeilDeakin

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6d3a1a9c05bd