Closed Bug 1630835 Opened 4 years ago Closed 4 years ago

Constructable stylesheets should probably notify the constructor document from the NOTIFY macro

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

But not always, I guess.

This line doesn't do anything for constructed stylesheets.

For most of the notifications I think that is just fine, because they'll notify the adopters which most of the time would end up in RecordShadowStyleChange as needed (or notifying the document itself).

But there's one event for which we differ in behavior, which is ShadowRoot::StyleSheetApplicableStateChanged. This one is interesting because it fires events and what not so you don't really want to call it more than once. So gotta be careful on the solution.

These events are only relevant for devtools, so probably not the highest priority.

Or I guess, for that same reason, that that is mostly relevant to the ApplicableStateChanged event and we can just move that bit there.

Ah, we don't even use that for ApplicableStateChanged... So maybe it's just redundant most of the time for stylesheets in shadow dom too...

This should have no behavior change, but makes the setup simpler and
more similar to the constructable sheets.

Depends on D71261

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fa9eb024124
Don't propagate associated document or shadow root to child sheets. r=nordzilla
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: