Closed Bug 1630873 Opened 3 months ago Closed 3 months ago

[mozperftest] refactor notebook naming

Categories

(Testing :: mozperftest, enhancement)

Version 3
enhancement

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: tarek, Assigned: axew1337)

Details

Attachments

(1 file)

Hey,
In Python, a good practice is to make the name of the file as small as possible, and to avoid as much redundancy as possible,
so I'd like to suggest to rename those:

python/mozperftest/mozperftest/metrics/notebook/customtransforms/__init__.py          
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_frame_retriever.py      
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_geomean_retriever.py       
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_replicate_retriever.py     
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_single_json_retriever.py      

Into:

python/mozperftest/mozperftest/metrics/notebook/transforms/__init__.py          
python/mozperftest/mozperftest/metrics/notebook/transforms/frame_retriever.py      
python/mozperftest/mozperftest/metrics/notebook/transforms/geomean_retriever.py       
python/mozperftest/mozperftest/metrics/notebook/transforms/replicate_retriever.py     
python/mozperftest/mozperftest/metrics/notebook/transforms/single_json_retriever.py      

and if all transforms are "retriever":

python/mozperftest/mozperftest/metrics/notebook/transforms/__init__.py          
python/mozperftest/mozperftest/metrics/notebook/transforms/frame.py      
python/mozperftest/mozperftest/metrics/notebook/transforms/geomean.py       
python/mozperftest/mozperftest/metrics/notebook/transforms/replicate.py     
python/mozperftest/mozperftest/metrics/notebook/transforms/single_json.py    
Flags: needinfo?(gmierz2)

:axew can you take care of this issue?

Flags: needinfo?(gmierz2) → needinfo?(xuxuanqi13)
Assignee: nobody → xuxuanqi13
Status: NEW → ASSIGNED
Attachment #9141944 - Attachment description: Bug 1630873: shorten transformer names. r=sparky → Bug 1630873: shorten transformer names, deleted obselete test. r=sparky
Attachment #9141944 - Attachment description: Bug 1630873: shorten transformer names, deleted obselete test. r=sparky → Bug 1630873 - Shorten transformer names, and delete an obselete file. r=sparky
Component: Performance → mozperftest
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/89385de4680f
Shorten transformer names, and delete an obselete file. r=sparky
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Flags: needinfo?(xuxuanqi13)
You need to log in before you can comment on or make changes to this bug.