Closed
Bug 1630873
Opened 5 years ago
Closed 5 years ago
[mozperftest] refactor notebook naming
Categories
(Testing :: mozperftest, enhancement)
Tracking
(firefox77 fixed)
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: tarek, Assigned: axew1337)
Details
Attachments
(1 file)
Hey,
In Python, a good practice is to make the name of the file as small as possible, and to avoid as much redundancy as possible,
so I'd like to suggest to rename those:
python/mozperftest/mozperftest/metrics/notebook/customtransforms/__init__.py
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_frame_retriever.py
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_geomean_retriever.py
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_replicate_retriever.py
python/mozperftest/mozperftest/metrics/notebook/customtransforms/custom_single_json_retriever.py
Into:
python/mozperftest/mozperftest/metrics/notebook/transforms/__init__.py
python/mozperftest/mozperftest/metrics/notebook/transforms/frame_retriever.py
python/mozperftest/mozperftest/metrics/notebook/transforms/geomean_retriever.py
python/mozperftest/mozperftest/metrics/notebook/transforms/replicate_retriever.py
python/mozperftest/mozperftest/metrics/notebook/transforms/single_json_retriever.py
and if all transforms are "retriever":
python/mozperftest/mozperftest/metrics/notebook/transforms/__init__.py
python/mozperftest/mozperftest/metrics/notebook/transforms/frame.py
python/mozperftest/mozperftest/metrics/notebook/transforms/geomean.py
python/mozperftest/mozperftest/metrics/notebook/transforms/replicate.py
python/mozperftest/mozperftest/metrics/notebook/transforms/single_json.py
Reporter | ||
Updated•5 years ago
|
Flags: needinfo?(gmierz2)
Comment 1•5 years ago
|
||
:axew can you take care of this issue?
Flags: needinfo?(gmierz2) → needinfo?(xuxuanqi13)
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee: nobody → xuxuanqi13
Status: NEW → ASSIGNED
Updated•5 years ago
|
Attachment #9141944 -
Attachment description: Bug 1630873: shorten transformer names. r=sparky → Bug 1630873: shorten transformer names, deleted obselete test. r=sparky
Updated•5 years ago
|
Attachment #9141944 -
Attachment description: Bug 1630873: shorten transformer names, deleted obselete test. r=sparky → Bug 1630873 - Shorten transformer names, and delete an obselete file. r=sparky
Updated•5 years ago
|
Component: Performance → mozperftest
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/89385de4680f
Shorten transformer names, and delete an obselete file. r=sparky
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(xuxuanqi13)
You need to log in
before you can comment on or make changes to this bug.
Description
•