1630899 - Update NETWORK_PAC_URL_SCHEME probe to collect data on release

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, task, P1)

Description

[Michal Novotny [:michal]]

We want the data from release too because the feature is likely to be used more in corporations where we cannot expect pre-release versions to be used.

Comment 1

[Michal Novotny [:michal]]

Attachment: Bug 1630899 - Update NETWORK_PAC_URL_SCHEME probe to collect data on release

Comment 2

[Michal Novotny [:michal]]

Attachment: request.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9141213 [details]
request.md

PRELIMINARY NOTES:
Release data isn't presently available on the TMO measurement dashboard since last December due to a data job fault. You will likely need to perform analysis on sql.tmo or another tool. Please reach out on Slack#fx-metrics or #telemetry:mozilla.org on Matrix for any assistance.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 82.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :michal is responsible for renewing or removing the collection before it expires in Firefox 82.

---
Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2d1aace7415
Update NETWORK_PAC_URL_SCHEME probe to collect data on release r=necko-reviewers,dragana

Comment 5

[Michal Novotny [:michal]]

Comment on attachment 9141205 [details]
Bug 1630899 - Update NETWORK_PAC_URL_SCHEME probe to collect data on release

Beta/Release Uplift Approval Request

• User impact if declined: We would like to get the data from release as soon as possible. The probe landed on 76 and this patch just modifies the probe to collect the data also on release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch doesn't change any code.
• String changes made/needed: none

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c2d1aace7415

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141205 [details]
Bug 1630899 - Update NETWORK_PAC_URL_SCHEME probe to collect data on release

Approved for 76.0b6.

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ba662200ecd

Comment 9

[Michal Novotny [:michal]]

Following table shows data from release:

day	total	ftp	other
2020-05-20	83072248	44	1727798
2020-05-21	75542781	37	1470436
2020-05-22	76547755	37	1531843
2020-05-23	59978721	30	946022
2020-05-24	57292267	35	897281
2020-05-25	76458201	84	1611380
2020-05-26	82339133	89	1791423
2020-05-27	82983061	45	1815111
2020-05-28	82928772	93	1828360
2020-05-29	79835218	87	1746296
2020-05-30	60200630	31	990974
2020-05-31	58009774	26	940291
2020-06-01	77080858	42	1561693
2020-06-02	83385366	103	1857625
2020-06-03	84153230	55	1899826

Comment 10

[Nhi Nguyen (:nhi)]

From the above table: On F76, over 2 week period, PAC scripts were downloaded with FTP 838 times, out of a total of more than 84 million PAC downloads. The ratio is really insignificant.