1630918 - Use prefers-reduced-motion media query for the tracking protection shield icon animation

Status: RESOLVED FIXED

(Firefox :: Protections UI, task)

Description

[Dão Gottwald [:dao]]

FWIW, when looking into this I could hardly see the animation. It's so subtle that maybe we should just remove it at this point?

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1630918 - Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh

Comment 2

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #0)

FWIW, when looking into this I could hardly see the animation. It's so subtle that maybe we should just remove it at this point?

What do you think?

Comment 3

[Johann Hofmann [:johannh]]

You're right that it is subtle but I also feel like that was the idea behind it. Needinfo Eric on the question whether we should remove it, though tbh I'm not sure if there's an urgency to do that on engineering side. Do we have evidence that it's causing performance issues, for example?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #3)

You're right that it is subtle but I also feel like that was the idea behind it.

From what I remember the original animation's intent was to draw attention, i.e. it was decidedly not subtle. It seems like this isn't the motivation anymore. Would you have added an animation in the first place if it wasn't for drawing attention?

Needinfo Eric on the question whether we should remove it, though tbh I'm not sure if there's an urgency to do that on engineering side. Do we have evidence that it's causing performance issues, for example?

It would presumably be the cheaper way forward here. You raised quite a few issues in phabricator (some of which I'm not sure how my patch would have caused them, so they might be preexisting issues?), and since this was just a little side project for me, I'm not sure I'll have time to dive deep into the tracking protection code and finish this. I'm still going to remove other toolkit.cosmeticAnimations.enabled consumers, so this might end up being the only one left.

Comment 5

[Dão Gottwald [:dao]]

I've updated the patch. I think you should still consider removing this animation, but that can happen independently from this bug (assuming my updated patch is basically okay).

Comment 6

[Johann Hofmann [:johannh]]

Yeah, let's consider that in a follow-up. To be clear I'm not particularly attached to the animation, but I'd like to consider it together with UX.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49365332dd15
Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset 49365332dd15 (Bug 1630918) for causing failures on browser_protectionsUI_animation_2.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Yl3BHby4TpqzjTjGb7XHXQ-0&revision=49365332dd15ff20e9238107c9da16f67685cf12&searchStr=browser-chrome

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299809513&repo=autoland&lineNumber=3740

Backout: https://hg.mozilla.org/integration/autoland/rev/a0a5a03791398797a309f7f7c9a1bf8c3e9c5a0e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/510334ad5c26
Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/510334ad5c26