Closed Bug 1630918 Opened 4 months ago Closed 4 months ago

Use prefers-reduced-motion media query for the tracking protection shield icon animation

Categories

(Firefox :: Protections UI, task)

task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox77 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

FWIW, when looking into this I could hardly see the animation. It's so subtle that maybe we should just remove it at this point?

Iteration: 77.1 - Apr 6 - Apr 19 → 77.2 - Apr 20 - May 3

(In reply to Dão Gottwald [::dao] from comment #0)

FWIW, when looking into this I could hardly see the animation. It's so subtle that maybe we should just remove it at this point?

What do you think?

Flags: needinfo?(jhofmann)

You're right that it is subtle but I also feel like that was the idea behind it. Needinfo Eric on the question whether we should remove it, though tbh I'm not sure if there's an urgency to do that on engineering side. Do we have evidence that it's causing performance issues, for example?

Flags: needinfo?(jhofmann) → needinfo?(epang)

(In reply to Johann Hofmann [:johannh] from comment #3)

You're right that it is subtle but I also feel like that was the idea behind it.

From what I remember the original animation's intent was to draw attention, i.e. it was decidedly not subtle. It seems like this isn't the motivation anymore. Would you have added an animation in the first place if it wasn't for drawing attention?

Needinfo Eric on the question whether we should remove it, though tbh I'm not sure if there's an urgency to do that on engineering side. Do we have evidence that it's causing performance issues, for example?

It would presumably be the cheaper way forward here. You raised quite a few issues in phabricator (some of which I'm not sure how my patch would have caused them, so they might be preexisting issues?), and since this was just a little side project for me, I'm not sure I'll have time to dive deep into the tracking protection code and finish this. I'm still going to remove other toolkit.cosmeticAnimations.enabled consumers, so this might end up being the only one left.

I've updated the patch. I think you should still consider removing this animation, but that can happen independently from this bug (assuming my updated patch is basically okay).

Flags: needinfo?(epang)

Yeah, let's consider that in a follow-up. To be clear I'm not particularly attached to the animation, but I'd like to consider it together with UX.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49365332dd15
Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/510334ad5c26
Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh
Flags: needinfo?(dao+bmo)
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.