1630947 - Expose ReportingObserver to workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrea Marchesini [:baku]]

The latest version of the reporting API exposes ReportingObserver and other interfaces to Workers.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1630947 - Update Reporting API - part 1 - ReportingObserver in workers, r?smaug

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1630947 - Update Reporting API - part 2 - tests for Workers, r?smaug

Depends on D71317

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfed9f2487d
Update Reporting API - part 1 - ReportingObserver in workers, r=smaug
https://hg.mozilla.org/integration/autoland/rev/18c357daf0f7
Update Reporting API - part 2 - tests for Workers, r=smaug

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=18c357daf0f7ace6bb629bc02478395b2d0be697&selectedJob=298152331

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=298152331&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/cf66def9cbd002f21bab8e55083a165f82ea0217

[task 2020-04-17T20:12:56.687Z] 20:12:56     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/reporting'
[task 2020-04-17T20:12:56.689Z] 20:12:56     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_dom_reporting0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/reporting -I/builds/worker/workspace/obj-build/dom/reporting -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_dom_reporting0.o.pp   Unified_cpp_dom_reporting0.cpp
[task 2020-04-17T20:12:56.689Z] 20:12:56     INFO -  In file included from Unified_cpp_dom_reporting0.cpp:83:
[task 2020-04-17T20:12:56.689Z] 20:12:56    ERROR -  /builds/worker/checkouts/gecko/dom/reporting/ReportingObserver.cpp:92:5: error: arguments must all be strong refs or caller's parameters when calling a function marked as MOZ_CAN_RUN_SCRIPT (including the implicit object argument).  'mGlobal' is neither.
[task 2020-04-17T20:12:56.689Z] 20:12:56     INFO -      mGlobal->NotifyReportingObservers();
[task 2020-04-17T20:12:56.689Z] 20:12:56     INFO -      ^~~~~~~
[task 2020-04-17T20:12:56.690Z] 20:12:56     INFO -  1 error generated.
[task 2020-04-17T20:12:56.691Z] 20:12:56     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:750: recipe for target 'Unified_cpp_dom_reporting0.o' failed
[task 2020-04-17T20:12:56.691Z] 20:12:56    ERROR -  make[4]: *** [Unified_cpp_dom_reporting0.o] Error 1
[task 2020-04-17T20:12:56.692Z] 20:12:56     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/reporting'
[task 2020-04-17T20:12:56.692Z] 20:12:56     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'dom/reporting/target-objects' failed
[task 2020-04-17T20:12:56.693Z] 20:12:56    ERROR -  make[3]: *** [dom/reporting/target-objects] Error 2
[task 2020-04-17T20:12:56.694Z] 20:12:56     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e84a9da02c
Update Reporting API - part 1 - ReportingObserver in workers, r=smaug
https://hg.mozilla.org/integration/autoland/rev/b55e8def98e8
Update Reporting API - part 2 - tests for Workers, r=smaug

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/53e84a9da02c
https://hg.mozilla.org/mozilla-central/rev/b55e8def98e8