Closed Bug 1631106 Opened 9 months ago Closed 9 months ago

Absorb LazyScriptCreationData into FunctionCreationData

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: tcampbell, Assigned: caroline)

References

Details

Attachments

(1 file)

The LazyScriptCreationData should be replaced by ScriptStencil. The inner function and bindings arrays should be stored in the gcthings list instead.

See Also: → 1617016

The simpler step as we finish removing flags from LazyScriptCreationData is to just absorb the struct into FunctionCreationData. We already have a Maybe<LazyScriptCreationData> field, so instead we can just inline the closedOverBindings and innerFunctionIndexes arrays.

Fortunately things are mostly in the right place to make this change: https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/js/src/frontend/Parser.cpp#1781-1792

Assignee: tcampbell → ccullen
Summary: Replace LazyScriptCreationData with ScriptStencil. → Absorb LazyScriptCreationData into FunctionCreationData
Pushed by ccullen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12aaa50f2285
Absord LazyScriptCreationData into FunctionCreationData. r=tcampbell
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.