Closed
Bug 1631106
Opened 6 years ago
Closed 6 years ago
Absorb LazyScriptCreationData into FunctionCreationData
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: tcampbell, Assigned: caroline)
References
Details
Attachments
(1 file)
The LazyScriptCreationData should be replaced by ScriptStencil. The inner function and bindings arrays should be stored in the gcthings list instead.
|
Reporter | |
Comment 1•6 years ago
•
|
||
The simpler step as we finish removing flags from LazyScriptCreationData is to just absorb the struct into FunctionCreationData. We already have a Maybe<LazyScriptCreationData> field, so instead we can just inline the closedOverBindings and innerFunctionIndexes arrays.
Fortunately things are mostly in the right place to make this change: https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/js/src/frontend/Parser.cpp#1781-1792
Assignee: tcampbell → ccullen
Summary: Replace LazyScriptCreationData with ScriptStencil. → Absorb LazyScriptCreationData into FunctionCreationData
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by ccullen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12aaa50f2285
Absord LazyScriptCreationData into FunctionCreationData. r=tcampbell
|
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•