1631114 - Make Handle<Maybe<>> more convenient

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tom S. (please needinfo tschuster)]

I am using Handle<Maybe<Value>>> in D64437 and there are some usability problems:

• I have to do handle.get.isSome() instead of just handle.isSome().
• I really want to just pass Nothing() to a parameter, instead of having to do

Maybe<JS::Value> nothing = Nothing();
f(Handle<Maybe<Value>>::fromMarkedLocation(&nothing));

(In this case I don't have access to a JSContext without changing a bunch of code)

Comment 1

[Jon Coppeard (:jonco)]

Please do try to avoid Handle::fromMarkedLocation. Ideally we would remove this but it's still necessary in a few places.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1631114 - Make Handle<Maybe<Value>> easier to use r?jandem

This adds WrappedPtrOperations and MutableWrappedPtrOperations specialisations for Maybe<T> to all basic Maybe operations to used on Rooted<Maybe<T>>, Handle<Maybe<T>>, etc. I didn't add all of them; in particular I found ptr() would conflict with the Rooted::ptr data member.

This also adds JS::NothingHandleValue for passing Nothing to a Handle<Maybe<Value>>.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73d7489248b6
Make Handle<Maybe<Value>> easier to use r=jandem

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/73d7489248b6