Closed Bug 1631132 Opened 5 years ago Closed 5 years ago

`mach try syntax` wants to include untracked files in the push

Categories

(Developer Infrastructure :: Try, defect)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1632688

People

(Reporter: jfkthame, Assigned: hwine)

References

(Regression)

Details

(Keywords: regression)

Since bug 1630047 landed -- at least, I think that's the culprit, though have not bisected to the level of individual changesets -- I'm seeing broken behavior when attempting to use mach try with "traditional" try syntax, e.g. commands like

 ./mach try -b do -p linux64 -u all

I have a variety of untracked files in my tree, which have always been ignored when pushing to try, but in the last couple days I'm suddenly seeing that mach try wants to hg add all these before pushing; I get a number of warnings about the amount of memory that will be needed (some of them are big files), and a long list of added files are reported by hg status output when "Creating temporary commit for remote...".

(This does not occur when using mach try chooser to do a try push; it seems to be specific to mach try [syntax].)

The command now also shows:

Nothing specified, nothing added.
Maybe you wanted to say 'git add .'?

... whenever I call it without uncommitted files.

I assume you must be using git rather than mercurial? Perhaps the same underlying issue, but slightly different symptoms depending on the version control system being used.

I think the difference is that hg addremove without explicit path argument implicitly adds all changes while git add does not.

already fixed -- be sure to update your workspaces

Thanks for the report.

Assignee: nobody → hwine
Group: firefox-core-security
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
Product: Firefox Build System → Developer Infrastructure
Group: firefox-core-security
You need to log in before you can comment on or make changes to this bug.