1631193 - Firefox Beta does not start on Wayland

Status: VERIFIED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Bartłomiej Piotrowski]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

1. Install org.mozilla.firefox from Flathub Beta
2. Start it from Wayland session (tested on GNOME)

Actual results:

Firefox does not start; "Error: no DISPLAY environment variable specified" is printed in terminal

Expected results:

Firefox actually starts

Comment 1

[Bartłomiej Piotrowski]

Attachment: Bug 1631193 - drop Wayland permissions from flatpak r=mtabara

Firefox still does not default to Wayland when it's available (or when
X11 socket is not accessible). This can be changed by MOZ_ENABLE_WAYLAND=1
but as it's not the default, it's safer to just drop access to Wayland.

Comment 2

[Emerson Bernier]

Changing fallback-x11 to x11 should be enough to fix this issue. Leaving --socket=wayland will make testing wayland easier for users without downsides.

Comment 3

[Bartłomiej Piotrowski]

As users need to define an environment variable with override command, I find it largely irrelevant. It’s about fixing the regression.

Comment 4

[Emerson Bernier]

It's relevant for users who come from distro package and have no idea about special wayland permission needed for flatpak.

--socket=wayland was added because users requested to add it and it doesn't cause any harm. --socket=x11-fallback does harm and it's the only one that needs to be removed.

Comment 5

[Bartłomiej Piotrowski]

Given that --socket=wayland is essentially useless without defining the variable, I still don't see why it should be included. Useless permissions cause harm.

Comment 6

[Emerson Bernier]

Firefox can run on wayland, on fedora it even uses wayland by default. The fact that not everyone will run it on wayland doesn't mean nobody will run it on wayland. How wayland permission is useless then? It's not like wayland permission decreases sandbox security unlike x11.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc4ad3fce1b7
drop Wayland permissions from flatpak r=mtabara

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9141479 [details]
Bug 1631193 - drop Wayland permissions from flatpak r=mtabara

Beta/Release Uplift Approval Request

• User impact if declined: Flatpak fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Flatpak fix.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Flatpak fix.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141479 [details]
Bug 1631193 - drop Wayland permissions from flatpak r=mtabara

Approved for 76.0b7.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e413ad1bd2a

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fc4ad3fce1b7

Comment 12

[Daniel Cicas [:dcicas], Release QA]

Hello
I can confirm that this issue is fixed on Fx 76.0b7 on Ubuntu 18.04.