Closed Bug 1631214 Opened 4 years ago Closed 4 years ago

Intermittent image/image-orientation-generated-content.html == image/image-orientation-generated-content-ref.html | image comparison, max difference: 255, number of differing pixels: 9900

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P5)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: heycam)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1631214 - Fix oriented image invalidation rectangle calculation when a Flip is present.
47 bytes, text/x-phabricator-request
Details | Review

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=298228600&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LNV-4pXGTiagC-XwKL4R3g/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LNV-4pXGTiagC-XwKL4R3g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2020-04-18T10:57:29.639Z] 10:57:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/image/image-orientation-generated-content.html | 1157 / 7255 (15%)
[task 2020-04-18T10:57:29.639Z] 10:57:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/image/image-orientation-generated-content-ref.html | 1157 / 7255 (15%)
[task 2020-04-18T10:57:29.639Z] 10:57:29 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (255, 9900) <= (1, 1)
[task 2020-04-18T10:57:29.639Z] 10:57:29 WARNING - REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/image/image-orientation-generated-content.html == layout/reftests/image/image-orientation-generated-content-ref.html | image comparison, max difference: 255, number of differing pixels: 9900
[task 2020-04-18T10:57:29.642Z] 10:57:29 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,
[task 2020-04-18T10:57:29.647Z] 10:57:29 INFO - REFTEST IMAGE 2 (REFERENCE): data:image/png;base64,
[task 2020-04-18T10:57:29.647Z] 10:57:29 INFO - REFTEST TEST-END | layout/reftests/image/image-orientation-generated-content.html == layout/reftests/image/image-orientation-generated-content-ref.html

Same type of failure as several others, only part of the image is draw, and it stops at the same point each time. Maybe the width and height are getting confused, it looks like it stops drawing at the shorter of the two.

I was getting similar (non-intermittent) failures on Android during the development of the patches, though I thought I'd fixed them. It was something to do with confusion about whether to use the oriented or unoriented space when notifying about invalid rectangles. Will look into it tomorrow.

Flags: needinfo?(cam)

Haven't been able to reproduce this so far today (either in the Android emulator or with a Linux x86_64 build).

Flags: needinfo?(cam)

(In reply to Intermittent Failures Robot from comment #5)

Platform breakdown:

  • linux1804-64-asan: 1

Luckily this is not Android specific! I've submitted a request to Pernosco to try to reproduce this.

If that doesn't work I've had pretty good success reproducing rare intermittents with writing a little script that creates 100 copies of the failing test.

It managed to reproduce it: https://pernos.co/debug/uPSwT6k7_m6x7_kcODro-w/index.html

(Though my time is limited this week, and next week I'm on PTO, so I may not get a chance to look into it until we're a week into these changes already being on Beta.)

Assignee: nobody → cam
Status: NEW → ASSIGNED
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca33a89c9b32
Fix oriented image invalidation rectangle calculation when a Flip is present. r=tnikkel

https://hg.mozilla.org/mozilla-central/rev/ca33a89c9b32

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: