1631230 - headers are shown with ellipsis in network analysis although the space is big enough

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Volkmar Wörner]

Attachment: network1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

I opened network analysis to inspect the headers of requests

Actual results:

The longer headers get shortened with ellipsis in the middle (see attached screenshot)

Expected results:

There is enough space to show the complete header or at least make the headers use the whole space available

Comment 1

[Seba S.]

Hi, volkmar.woerner!

Thanks for your contribution!

I could reproduce the described behavior, but I think this is not an issue, so far, I assume this can be edited, but I'm not sure about it so I will add product and component so any other partner with the proper knowledge on the matter can give you correct information.

Regards,

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (non,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@bomsy: this doesn't seem to be a problem anymore since we are now wrapping the header value into a new line correct?
Honza

Comment 5

[Hubert Boma Manilla (:bomsy)]

I can still see it.

To fix we can remove the crop from here
https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/devtools/client/netmonitor/src/components/request-details/HeadersPanel.js#450

Comment 6

[Brad Werth [:bradwerth]]

Assigning to GSoC intern Manas Khurana as a good first bug.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 8

[manas]

Attachment: Bug 1631230 - Remove crop property. r=bradwerth

Comment 9

[Geoff Lankow (:darktrojan)]

I've set check-in needed on Phabricator, checkin-needed-tb on Bugzilla is not what you're looking for.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffd2e6786655
Remove crop property. r=Honza,bradwerth,bomsy

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ffd2e6786655