1631293 - 100% CPU usage when moving cursor with image overlay

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Link]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

On www.spotwx.com website
For example :

https://spotwx.com/products/grib_index.php?model=hrrr_wrfprsf&lat=31.80289&lon=-87.42371&tz=America/Chicago

Move the cursor over graphs timelines of data to see the overlayed image. Keep moving the cursor over the graphs.

Actual results:

CPU usage can go as high as 100% if I continue moving the cursor over the timeline graphs with an Intel i5-5200u with Intel graphics 5500.

It does affect the responsiveness of the page and cursor. It's worse on an older CPU like a Intel Core 2 duo E6850 where it becomes very slow with AMD Radeon 7770.

Expected results:

Moving the curcor over timeline graphs should make the CPU usage go around 30 % or less with an Intel i5-5200u.

Comment 1

[Link]

Using mozregression, this is the commit that causes the issue :

2020-04-19T16:29:01.833000: INFO : application_buildid: 20200416201406
2020-04-19T16:29:01.833000: INFO : application_changeset: aff8eef07d078b20be9c4b7d6dfb689998fb11fa
2020-04-19T16:29:01.833000: INFO : application_display_name: Firefox Nightly
2020-04-19T16:29:01.833000: INFO : application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
2020-04-19T16:29:01.833000: INFO : application_name: Firefox
2020-04-19T16:29:01.833000: INFO : application_remotingname: firefox
2020-04-19T16:29:01.833000: INFO : application_repository: https://hg.mozilla.org/integration/autoland
2020-04-19T16:29:01.833000: INFO : application_vendor: Mozilla
2020-04-19T16:29:01.833000: INFO : application_version: 77.0a1
2020-04-19T16:29:01.833000: INFO : platform_buildid: 20200416201406
2020-04-19T16:29:01.833000: INFO : platform_changeset: aff8eef07d078b20be9c4b7d6dfb689998fb11fa
2020-04-19T16:29:01.833000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2020-04-19T16:29:01.833000: INFO : platform_version: 77.0a1
2020-04-19T16:29:33.053000: INFO : b''
2020-04-19T16:29:33.053000: INFO : b'###!!! [Child][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost'
2020-04-19T16:29:33.053000: INFO : b''
2020-04-19T16:29:33.122000: INFO : b''
2020-04-19T16:29:33.122000: INFO : b'###!!! [Child][MessageChannel::SendAndWait] Error: Channel error: cannot send/recv'
2020-04-19T16:29:33.122000: INFO : b''
2020-04-19T16:29:36.991000: INFO : Narrowed integration regression window from [eb5dd046, 65951cbe] (3 builds) to [eb5dd046, aff8eef0] (2 builds) (~1 steps left)
2020-04-19T16:29:37.012000: DEBUG : Starting merge handling...
2020-04-19T16:29:37.012000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=aff8eef07d078b20be9c4b7d6dfb689998fb11fa&full=1
2020-04-19T16:29:37.840000: DEBUG : Found commit message:
Bug 1587713 - Remove the late blob rasterization code. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D49186

2020-04-19T16:29:37.840000: DEBUG : Did not find a branch, checking all integration branches
2020-04-19T16:29:37.840000: INFO : The bisection is done.
2020-04-19T16:29:37.855000: INFO : Stopped

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Mayank Bansal]

https://perfht.ml/3ewKSFQ

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1631293 - Clear the blob image dirty rect after preparing blob rsaterization requests. r=jrmuizel

This line was accidentally removed here https://hg.mozilla.org/integration/autoland/rev/100387beceed5894fa594a07845a149cbddfb1b8#l5.486

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bef6ce79d8f6
Clear the blob image dirty rect after preparing blob rsaterization requests. r=jrmuizel

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bef6ce79d8f6

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #25668 (as of Tue, 21 Apr 2020 09:23:12 GMT) ==

Improvements:

13% tsvg_static windows10-64-shippable-qr opt e10s stylo 47.74 -> 41.74
3% tart linux64-shippable-qr opt e10s stylo 3.44 -> 3.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25668

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Alexandru, this was a fix of a regression. It looks like we failed to catch it originally.

Comment 11

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Thanks you Jeff, this is the entire alert.
== Change summary for alert #25668 (as of Tue, 21 Apr 2020 09:23:12 GMT) ==

Improvements:

33% tsvgx linux64-shippable-qr opt e10s stylo 362.29 -> 241.49
33% tsvgx linux64-shippable-qr opt e10s stylo 362.23 -> 241.99
19% tsvgr_opacity windows10-64-shippable-qr opt e10s stylo 121.81 -> 98.35
15% tsvgr_opacity linux64-shippable-qr opt e10s stylo 124.49 -> 105.81
13% tsvg_static windows10-64-shippable-qr opt e10s stylo 47.74 -> 41.74
13% tsvg_static linux64-shippable-qr opt e10s stylo 49.85 -> 43.61
3% tart linux64-shippable-qr opt e10s stylo 3.44 -> 3.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25668

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

CPU used: Intel i5-6500
I didn't manage to reproduce the issue as described, although there did seem to be a high CPU usage while hovering over the timeline graphs.
CPU usage went as high as 60-65% on the Firefox process.
After the fix was applied, CPU usage only climbed up to around 40% across all tested OS's (Win 10, Ubuntu 18.04 and macOS 10.15). This was verified using the latest nightly 78 and latest beta 77 builds.

Please note that on a Ryzen 3700x the Fx process barely rose to ~20% CPU usage.

Marking the issue as verified fixed.