1631303 - PiP controls can break (macOS, release) - clicking blue PiP indicator on BBC iPlayer video did not show player (playerWin is null)

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[:Gijs (back August 25; he/him)]

My partner hit this earlier in the weekend (when bmo was down). Unclear what caused it to happen; restarting Firefox fixed things. But the console showed that we were hitting:

https://searchfox.org/mozilla-central/rev/35f2245f17841db50820221f3838ec55744cccd1/toolkit/components/pictureinpicture/PictureInPicture.jsm#143

and playerWin was null, so the if condition threw. Presumably the weakref can (or could, if this is fixed in 76/77) return null? That seems reasonable for a weakref, but the code doesn't seem to catch that case...

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1631303 - Properly handle the case where the PiP player window weakref returns null. r?Gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2eabb1ec039
Properly handle the case where the PiP player window weakref returns null. r=Gijs

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a2eabb1ec039

Comment 4

[Maria Berlinger [:mberlinger], Fxa/Subplat]

Hello,
are there any STR that manual QA can use to verify this? Thank you!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I don't believe so, no - it was very intermittent and hard to reproduce reliably.