1631533 - Make sync fields observe DidChange instead of DidSet

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

And let it observe the old value as needed.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631533 - Make sync fields observe DidChange instead of DidSet. r=nika

And provide the old value to that callback.

I'm going to need this for zoom.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adcfa8af679c
Make sync fields observe DidChange instead of DidSet. r=nika

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631533 - Reintroduce DidSet because user activation state still needs it. r=nika

Comment 4

[Andrei Ciure[:aciure]]

Backed out changeset adcfa8af679c (bug 1631533) for causing test_useractivation_transient.html failures
https://hg.mozilla.org/integration/autoland/rev/b1a9eb1f08dfb1ec9908953a0f889dde1ef73252

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cmochitests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-mochitest-plain-e10s-4%2Cm%284%29&fromchange=0ff89c708ad7488fd4f156603be42c3009952ee9&tochange=b1a9eb1f08dfb1ec9908953a0f889dde1ef73252

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298483231&repo=autoland

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631533 - Allow to get old value in synced field's DidSet. r=nika

This is needed for zoom because it only fires events when values
actually change for example, but seems useful more generally to
potentially avoid wasted work.

We can't just notify on change because user activation depends on the
time on which DidSet gets called.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e27ee92a9e35
Allow to get old value in synced field's DidSet. r=nika

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e27ee92a9e35