1631568 - Improve the interface of nsLayoutUtils::GetFrameForPoint and fix callers that pass in an incorrect viewport type

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

In bug 1556556, we added a new FrameForPointOption for nsLayoutUtils::GetFrameForPoint(), named IsRelativeToLayoutViewport.

Later in the patch series we introduce a RelativeTo structure which groups a frame with a viewport type that can be either layout or visual.

We can clean this up a bit by having GetFrameForPoint take a RelativeTo parameter, and replacing the IsRelativeToLayoutViewport flag with the use of ViewportType::Layout in that parameter.

Comment 1

[Botond Ballo [:botond]]

Going through the call sites of this function has also turned up call sites that were passing in the incorrect viewport type, so this change may fix some correctness issues as well.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1631568 - Move ViewportType and RelativeTo into a separate header. r=tnikkel

This allows headers which nsLayoutUtils.h includes to use these types without
creating a circular dependency.

As part of this change, the types are also moved into namespace mozilla.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1631568 - Have nsLayoutUtils::GetFrameForPoint() and GetFramesForArea() take a RelativeTo parameter. r=tnikkel

This removes the need for FrameForPointOptions::IsRelativeToLayoutViewport,
and makes sure each call site of these functions indicates whether the
input point/rect is in visual or layout coordinates.

Several call sites were passing in layout coordinates without setting the
IsRelativeToLayoutViewport flag, which this patch corrects.

Depends on D71704

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cc0881e244b
Move ViewportType and RelativeTo into a separate header. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/edd529f7a9c5
Have nsLayoutUtils::GetFrameForPoint() and GetFramesForArea() take a RelativeTo parameter. r=tnikkel

Comment 5

[Kartikaya Gupta (email:[e-mail])]

For posterity this was backed out along with bug 1556556, see this comment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0a06e58b247
Move ViewportType and RelativeTo into a separate header. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/cd5ab4e2f7a8
Have nsLayoutUtils::GetFrameForPoint() and GetFramesForArea() take a RelativeTo parameter. r=tnikkel

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b0a06e58b247
https://hg.mozilla.org/mozilla-central/rev/cd5ab4e2f7a8