1631581 - Rename legacy Web IDL extended attributes

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P2)

Description

[Domenic Denicola]

In https://github.com/heycam/webidl/pull/870 we renamed many legacy Web IDL extended attributes to make their usage more clear:

• [NamedConstructor] -> [LegacyFactoryFunction]
• [LenientSetter] -> [LegacyLenientSetter]
• [LenientThis] -> [LegacyLenientThis]
• [NoInterfaceObject] -> [LegacyNoInterfaceObject]
• [TreatNullAs=EmptyString] -> [LegacyNullToEmptyString]
• [OverrideBuiltins] -> [LegacyOverrideBuiltins]
• [TreatNonObjectAsNull] -> [LegacyTreatNonObjectAsNull]
• [Unforgeable] -> [LegacyUnforgeable]

This bug is a FYI in case you want to update your .webidl files and bindings implementation to align with the spec-side renames. Doing so should not change the generated code at all.

Comment 1

[Edgar Chen [:edgar]]

Not actively working on this.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 1: Rename NoInterfaceObject to LegacyNoInterfaceObject r=edgar

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 2: Rename NamedConstructor to LegacyFactoryFunction r=edgar

Depends on D111209

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 3: Rename LenientThis to LegacyLenientThis r=edgar

Depends on D111210

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 4: Rename Unforgeable to LegacyUnforgeable r=edgar

Depends on D111211

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 5: Rename TreatNullAs=EmptyString to LegacyNullToEmptyString r=edgar

Depends on D111212

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 6: Rename LenientSetter to LegacyLenientSetter r=edgar

Depends on D111213

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 7: Rename OverrideBuiltIns to LegacyOverrideBuiltIns r=edgar

Depends on D111214

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1631581 - Part 8: Rename TreatNonObjectAsNull to LegacyTreatNonObjectAsNull r=edgar

Depends on D111215

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66755e4bf4d9
Part 1: Rename NoInterfaceObject to LegacyNoInterfaceObject r=edgar
https://hg.mozilla.org/integration/autoland/rev/a687ca563fcc
Part 2: Rename NamedConstructor to LegacyFactoryFunction r=edgar
https://hg.mozilla.org/integration/autoland/rev/630564ad6440
Part 3: Rename LenientThis to LegacyLenientThis r=edgar
https://hg.mozilla.org/integration/autoland/rev/87f9f0b12dba
Part 4: Rename Unforgeable to LegacyUnforgeable r=edgar
https://hg.mozilla.org/integration/autoland/rev/1c0d8b69d139
Part 5: Rename TreatNullAs=EmptyString to LegacyNullToEmptyString r=edgar
https://hg.mozilla.org/integration/autoland/rev/832b8a9fdc78
Part 6: Rename LenientSetter to LegacyLenientSetter r=edgar
https://hg.mozilla.org/integration/autoland/rev/735010ff3c3f
Part 7: Rename OverrideBuiltIns to LegacyOverrideBuiltIns r=edgar
https://hg.mozilla.org/integration/autoland/rev/69df44c2f234
Part 8: Rename TreatNonObjectAsNull to LegacyTreatNonObjectAsNull r=edgar

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/66755e4bf4d9
https://hg.mozilla.org/mozilla-central/rev/a687ca563fcc
https://hg.mozilla.org/mozilla-central/rev/630564ad6440
https://hg.mozilla.org/mozilla-central/rev/87f9f0b12dba
https://hg.mozilla.org/mozilla-central/rev/1c0d8b69d139
https://hg.mozilla.org/mozilla-central/rev/832b8a9fdc78
https://hg.mozilla.org/mozilla-central/rev/735010ff3c3f
https://hg.mozilla.org/mozilla-central/rev/69df44c2f234